[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 10/13] vpci/header: reset the command register when adding devices
- To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 7 Feb 2022 16:05:57 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=15dLJ1kaBNPyyCxQhByvkocAZParuX/lDB4KtnLwn20=; b=kHnPr2PsUANVvyBboHY1FoFHHIJQxbQ9lBCxLqddg4YTU9Ku1VabRlkRiZ9zpXKjur90c1B4QwGd5ccU956Omn+w9Ra4NBl+fKVBr2hnBNCBASUN/U2LaRuWijsyEnOsmtE2hxR41Gg46x1JW7vSzidwAqafyO9i3B36XQQwOhPX16Ok7vSl1u1hrA/2lpK+llmc1yfnYwSU2S+np0WSzKlyNp8AZDkly+tBaXXvVNS8ahkHyqLI5RDpKvxjFj7W44nTe5AcBE+EJDrr9/HcKYXcSZhqymBHQ1VbTVeYhh4sKc5YOQzjGwjFn6H9OPTunDt6+w4R7t3qKRJRLGue8A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XzT3TL7qZaQ1nHPjkstil2CB6QqfY2Z2hB68Umftx+XS14tQOe4j0LEpQYTW8/1Or49ggtdYhOEbKab1SOW7FqbwTUl7z8BDuDsLDW/PL2Fozir8vo7ZwLXXh4i4x6RYbGfvSVID3mnrOnMEx2B5B0eQgey6aQe7kYHa0hvxsRyZSlhIyKNDoAA27MmmpxA9wqwh93uNevZbO0Vp0rZDqTJ37Xmh1sPXVSeMtu6mGFj0fiItI2xjaQSnvE0Ikx+KYnfglUvumdJkMR89kJ4yf/sygcDSAMNlUkecmnAMYNeaQOVd5fVQdgbcYOm3MUGGl6kLMwKR5YfxuAgT5F1AqQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "george.dunlap@xxxxxxxxxx" <george.dunlap@xxxxxxxxxx>, "paul@xxxxxxx" <paul@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 07 Feb 2022 15:06:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 07.02.2022 15:46, Oleksandr Andrushchenko wrote:
> On 07.02.22 16:31, Jan Beulich wrote:
>> But: What's still missing here then is the separation of guest and host
>> views. When we set INTx behind the guest's back, it shouldn't observe the
>> bit set. Or is this meant to be another (big) TODO?
> But, patch [PATCH v6 09/13] vpci/header: emulate PCI_COMMAND register for
> guests
> already takes care of it, I mean that it will set/reset INTx for the guest
> according to MSI/MSI-X. So, if we squash these two patches the whole
> picture will be seen at once.
Does it? I did get the impression that the guest would be able to observe
the bit set even after writing zero to it (while a reason exists that Xen
wants the bit set).
Jan
|