[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/2] x86/mm: tidy XENMEM_{get,set}_pod_target handling
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 4 Feb 2022 10:36:33 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FSRIHbcLpCujUBzdmAjhOBMcVTvBUzvxjySGwyZ0sRU=; b=ZFgP4RhCV0EUR4bls1+izCg6OUKH868Bgf1oVegwkJ8zBK+UsyKfiC27jkWUK5rzP14cW4OCgrV+pxMhCHJmjmt0s19ooQcOdR5umwV9UwmEumc6zKfvMJuuQvdKy+1t4Qc+M7niMNOMskOaYnXaPP6sE0FOBEKEeolwYYHvzCDJYpAb6NxmeoC9a4fgcPGmnM6z0SLa91fLWlzr/skevOXiqK4PFQY2jTf7aP+U75HccqfvNQN/ubbbjAflKKJu5OXBA3+8M9nqnfVgU9lqyeG4affL5CMI2GsyxnNgR6lFUENH0f2jS2Le+lt6htPnlGwgOu8kNaljOtp+gtVwGw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MaCqQ9Bab8tiBbx1pjq9kQkBOnUs+y1P72hXL9Ngj/2Y1bFSEu/CHwHSE6azItUcpm3/g9hf9B1BJc2+crEaMnOXQN0jdVF1a4WiNZi42rZ6mVpS7Si5gASbZxNDdt8TdrBk5GK+8kr3Ax6hckGgxfcOaEZuTVGsGucZYIZzvta5eZU3CyOYSe+gbUVwITwFIV8UsMWfYyC4YwWbxMQ6TCPkrwFaqQlaf0dC0aCQmgq//ABIAN4LwZVWX/Jp+uypluimQAXyoTXFueLb7grN0YU5+Pr/yT46QomyXkneIP/zHkXvhmRGl/LHpsyXaaQ7dO0bWrLxpwVRHsATroiujw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
- Delivery-date: Fri, 04 Feb 2022 09:36:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04.02.2022 10:28, Roger Pau Monné wrote:
> On Wed, Feb 02, 2022 at 04:29:37PM +0100, Jan Beulich wrote:
>> On 02.02.2022 16:14, Roger Pau Monné wrote:
>>> On Tue, Jan 04, 2022 at 10:41:53AM +0100, Jan Beulich wrote:
>>>> Do away with the "pod_target_out_unlock" label. In particular by folding
>>>> if()-s, the logic can be expressed with less code (and no goto-s) this
>>>> way.
>>>>
>>>> Limit scope of "p2m", constifying it at the same time.
>>>
>>> Is this stale? I cannot find any reference to a p2m variable in the
>>> chunks below.
>>
>> Indeed it is, leftover from rebasing over the introduction of
>> p2m_pod_get_mem_target() in what is now patch 1. Dropped.
>
> I'm happy with this change with the commit adjusted:
>
> Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks.
> Not sure if you can commit this now regardless of patch 1?
I think it can be moved ahead; there looks to be only a minor contextual
dependency.
Jan
|
