[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86


  • To: Anthony Perard <anthony.perard@xxxxxxxxxx>
  • From: Jane Malalane <Jane.Malalane@xxxxxxxxxx>
  • Date: Mon, 31 Jan 2022 15:54:21 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Prv3EJWTyPHuaPriPZoNxCaQPiKljE0vKS0RDs5UYVc=; b=c6NL4rHnHYqo7iFMMXVG2vdLkPPl5ZobUDDGQ3vrxmeVctRYh+CsiTrccUDVO+G8GPugY4YGLlLO9wuWcSJ5YdYNO9wjtQPxu+fG6M1GYh9MXTQU1ZIDNisVPziC+6O0+3dre6PcZLlF9q6iTk4OHsZCdKzBigKTNZF1pcdPUuDS+deOf/yGJ8YkGjGNn8atqx9cZIWKZq1te8r81hsjmK+8nhuzAtPOEt+RdjrgH5mFLHHL4BtKE4TcbaunmVanohexMJ2F3fY+pzowdDxiJMwrHvEJxpau8+NUm+NBdK5vPJxZHXSOCY3zc+ruo9fu3aawhIOAcdDSg58q5cbfIA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eatEvmeJ/T27iyGG8l/tyfH+zuR3chfDOXknneR86N8tO21RrCH/m+ifyvWeavJWJMNe2erOgG74BUyM4tG/UdkoLFCkaMf9rTAurejO/C3I6dzp7hKUb+0AaWkaGun6fKRJSpUURfXRAt10gku1yK1GksOT/Pv5vAFvURhZ3fTITMaTizrqlb/p/9algc6hNfpjpBwOIsiFss/0DBFs2aOB8IDLl2518l3Yjq70mAXQCqcblmPXM/esKw7V83Xc3t9BKONxpfFCi0FVwMJOwz4X7fBKvqDmKf/8IEmnS9XeGWJTXAOYWrFmo4Z6OZtSEesC2PKCE8XI4OZB3a+cag==
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "Juergen Gross" <jgross@xxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, "George Dunlap" <George.Dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, "Julien Grall" <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • Delivery-date: Mon, 31 Jan 2022 15:55:09 +0000
  • Ironport-data: A9a23:WHwztqLymK8yTC/QFE+R0JMlxSXFcZb7ZxGr2PjKsXjdYENShWMCm 2MZXm6Pa/jYNmHzLYxzaIq2o00G7MKAx4IxHVNlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUakideSc+EH170Us4wrZj6mJVqYPR7z2l6 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2ypMBfw epGraC8CiYJN4P0neMPaglXRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr LpBdW5LPkvra+GemdpXTsFOj8IuauziOIobs3dt5TrYEewnUdbIRKCiCdpwgmxt2pAfQqu2i 8wxORBgdD7ffh52BHQQOMgzl/uapEDZbGgNwL6SjfVuuDWCpOBr65DTN97Sds2PVN9itE+Sr WLb/Ez0GhgfcteYzFKt6Wmwj+XCmSf6XoM6F7Ci8PNuxlqJyQQ7AhAMSUGyp/X/j0ekQs9eM GQd4C9opq83nGSoQ8f8WVukoXeClh8aR9dUVeY97WmlyLfSpQCQBWEGTztIQN0gqMIyAzct0 zehgNfBFTFp9rqPRhq15rqS6D+/JyURBWsDfjMfCxsI5cH5p4M+hQ6JScxseIa3gcfyAirY2 C2RoW41gLB7pcwW06S2+3jXjjTqoYLGJiY37AjKWmOu7itieZWoIYev7DDmAe1oddjDCAPb5 T5dxpbYvLtm4YyxeDKle94dMriW7O65PH79oVdBJ5wm5Q299Cv2FWxP2w1WKEBsO8cCXDbmZ k7PpA9cjKNu0GuWgbxfONzoVZlzpUT0PZG8D62PMIISCnRkXFLfpElTiVisM3cBeaTGuYU2I t+lfMmlFh724ow3nWPtF4/xPVLGrx3SJF8/p7imlXxLMpLEPRZ5rIvp1nPUNIjVC4vf+G3oH y53bZfi9vmmeLSWjtPr2YASN0sWCnMwGIr7rcdaHsbafFY9RTF+U6+PkO9wE2CAo0izvr2Sl p1achQAoGcTeFWdcVnaApydQO6HsWlDQYITYnV3YAfAN4kLaoez9qYPH6bbjpF8nNGPOcVcF qFfE+3ZW6wnYm2ep1w1MMehxKQ/KkXDrV/ebkKNPWlkF7Y9FlOhxzMRVla1nMX4JnDp5ZJWT nzJ/l6zfKfvsCw7Up6ONqrzngzg1ZXf8corN3b1zhBoUByE2KBhKjDrj+9xJMcJKB7ZwSCd2 RrQChAdzdQhaadsmDUQrazb/YqvDcVkGU9WQzvS4bqsbHGI9Wu/245QFu2PeGmFBm/z/ayjY 8RTzu39b6JbzAob7dIkHuY517866vvuu6ReklZuEkLUYgn5EbhnOHSHg5VC7/Uf2r9DtAKqc UuT4d0Ga66RMcboHQdJdgooZ+iOz98OnTzW4ahnKUn2/nYvrrGGTV9TL1+HjykEdOl5N4Ysw OEAvs8K6lPg1kp2Y4je1i0NrjaCNH0NVakjp6o2Oo6zh1p50ExGbLzdFjTyvMOFZeJTPxR4O TSTnqfD2ehRnxKQb3opGHHR9uNBnpBS6gtSxVoPKlnVyNrIgvg7gE9Y/TgtF1kHyxxG16R4O 3RxNl0zLqKLpm86iM9GVmGqOgdAGBzGpRChlwpXzDXUHxuyS2jADGwhIuLcrkkW/lVVciVf4 LzFmn3uViznfZ2p0yY/MaK/RycPkTClGtX+pf2a
  • Ironport-hdrordr: A9a23:CeI3pazlHzq9sBo3KprCKrPxj+skLtp133Aq2lEZdPULSKOlfp GV8MjziyWYtN9IYgBcpTiBUJPwJE81bfZOkMcs1MSZLXXbUQyTXcBfBOrZsnLd8kjFmNK1up 0QCpSWZOeAbmSSyPyKmjVQcOxQgOVvkprY/ds2pk0FJWoBCsFdBkVCe32m+yVNNVN77PECZf 6hD7981lydkAMsH6OG7xc+Lor+juyOsKijTQ8NBhYh5gXLpyiv8qTGHx+R2Qpbey9TwJ85mF K10DDR1+GGibWW2xXc32jc49B9g9360OZOA8SKl4w8NijssAC1f45sMofy/gzd4dvfrWrCou O85CvIDP4DrU85uVvF+CcF7jOQlArGLUWSkWNwz0GT+vARDwhKdPapzbgpDCcxrXBQ4e2UmZ g7rl6xpt5ZCwjNkz/64MWNXxZ2llCsqX5niuILiWdDOLFuIoO5ArZviX+9Pa1wVB4S0rpXW9 WGzfuskMp+YBefdTTUr2NvyNujUjA6GQqHWFELvoiQ3yJNlH50wkMEzIhH901wuK4VWt1B/a DJI65onLZBQosfar98Hv4IRY+yBnbWSRzBPWqOKRDsFb0BOXjKt5nriY9Fqd2CadgN1t8/iZ 7BWFRXuSo7fF/vE9SH2NlR/hXEUAyGLH3QIwFllu5EU5HHNcnW2By4OScTepGb0oUi6+XgKo SOBK4=
  • Ironport-sdr: /XB4q8+4zDo8zUTsuFlOmFO29N2XgvNV9ozG4t8DjYO+MR+SGI9scRgqRHBpHKgBUeOsYuBDS7 yTITJGE6EaY0Q79cF2PQ+70NyUvOgZpi3EJB/P8ZGzHV48fFZC/Ug/8w3APe4IlI5/NPbu8YOS bEotkPyx3i3qvhP2Ur0hbpP+JXt35rdn3W33tIwZsXv96BOYm+j8NZfnf6vat+J5X4ySJq9HdX W5wZ2nqlahPHABzxhiyQQSSMyIyabkSnpGjvlCJcZNioSJbVgql2h1rMnluY8nGyjw6MkYYeJJ 1egILrm/H6dqQeotaVC9yWMZ
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHYE5d4GSao6/4dAkKp8GGbQShiJax4qxGAgASjWoA=
  • Thread-topic: [PATCH 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86

On 28/01/2022 17:04, Anthony PERARD wrote:
> On Thu, Jan 27, 2022 at 04:01:32PM +0000, Jane Malalane wrote:
>> Add XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_xapic and
>> XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_x2apic to report accelerated xapic
>> and x2apic, on x86 hardware.
>> No such features are currently implemented on AMD hardware.
>>
>> For that purpose, also add an arch-specific "capabilities" parameter
>> to struct xen_sysctl_physinfo.
>>
>> Signed-off-by: Jane Malalane <jane.malalane@xxxxxxxxxx>
>> Suggested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> ---
>>   tools/golang/xenlight/helpers.gen.go |  4 ++++
>>   tools/golang/xenlight/types.gen.go   |  6 ++++++
> 
> Note for committers: Please regenerate the go bindings, there are
> out-of-sync with libxl_types.idl at the moment.
> 
>> diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c
>> index 1feadebb18..33da51fe89 100644
>> --- a/tools/libs/light/libxl_x86.c
>> +++ b/tools/libs/light/libxl_x86.c
>> @@ -866,6 +866,17 @@ int libxl__arch_passthrough_mode_setdefault(libxl__gc 
>> *gc,
>>       return rc;
>>   }
>>   
>> +void libxl__arch_get_physinfo(libxl_physinfo *physinfo,
>> +                              xc_physinfo_t xcphysinfo)
> 
> It might be better to pass "xcphysinfo" as a pointer, otherwise I think
> a copy of the whole struct is made when calling this function.
> 
Will correct this, thanks.
> 
> In any case, the tool part of the patch looks good:
> Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> 
> Thanks,
> 

Jane.

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.