[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 06/14] vpci/header: implement guest BAR register handlers
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- Date: Mon, 31 Jan 2022 14:51:35 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tm1P+0VuN93o5CakgosbqIzl7aA7jai26H+1+0dHoPk=; b=lX8UjJB1jC1H6mprFmvn7lFZ45LXSt9qNlQFyfDSWlNgxF40E+4+YJ0XZDeFgJqslVYLyaekkIbLsRw4oRrI1WuOvUf+WOUA18HFFplDUHGhIgkjKofonN+GoINtzNx6IZJDzPoQUqfUS9d3D27wH0Oa+24nB7YRvoj4i3fJPqADvKSP+BIqlfLhkqU/Y0CStk7ihbGfuEiMKd03heIqDHfNvgKLIPUOIf8XYx/3/bCoAqhed1rBFzttnjTWFo2qV3EvJhw5n2dyDW/jEarBoR5adjTq20Co3PEk4YEs4GkyWkovM6nsr7OOev46rytqeNtllsxCb9wOPdHakJiSyw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ICn4NGMHj7J4RKDfucwXyqvmpKw8/WBbPGEoeH3nFtOLcYf4c8hEUgcEtA5dLukHbkxOQ248AuRaKvhXAXvy9XRuY1aW4igjuLTMsI92bheGeslBoxuPDWE1aOgUZYDasLfrEClODZxKQdhPzdj66S9UWLmt/nAHiVPjp35wgq+FUFWgxZd3j4BKz64RCqfJadp4UjhDjd3K1SIrv+nsHi2nQrfp4DvJY40ZtkasYnxythKapLa69A7HrZTu3C/gIQDyc35TJN32dlm+PLQpae6GeKmfAP4WHSwquRgun0QceJdCsPhgaTILXM4l2y0QC4dHxRe/vouWLmcXQhZHcA==
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "george.dunlap@xxxxxxxxxx" <george.dunlap@xxxxxxxxxx>, "paul@xxxxxxx" <paul@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- Delivery-date: Mon, 31 Jan 2022 14:52:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHX4ewHyWAyD811HEGp8pIjUuVWNaxfndGAgB2tWgCAABW/AIAAP1GA
- Thread-topic: [PATCH v5 06/14] vpci/header: implement guest BAR register handlers
>>> I wonder whether we need to protect the added code with
>>> CONFIG_HAS_VPCI_GUEST_SUPPORT, this would effectively be dead code
>>> otherwise. Long term I don't think we wish to differentiate between
>>> dom0 and domU vPCI support at build time, so I'm unsure whether it's
>>> helpful to pollute the code with CONFIG_HAS_VPCI_GUEST_SUPPORT when
>>> the plan is to remove those long term.
>> I would have it without CONFIG_HAS_VPCI_GUEST_SUPPORT if you
>> don't mind
> Well, I guess if it's not too intrusive it's fine to add the defines,
> removing them afterwards should be easy.
It is intrusive: it is easy to add such a define in struct vpci, but then you
need
ifdefery in xen/drivers/vpci/header.c to sort out the case when it is defined or
not. I can still do that if you insist
>
> Thanks, Roger.
Thank you,
Oleksandr
|