[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 02/23] VT-d: have callers specify the target level for page table walks
- To: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 31 Jan 2022 11:04:48 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k5JlUXmcB7MPs+D0hZ8LhjxoVuh7H9eAtsRXrzfMMzI=; b=Le5E0bQ3nrFUZXl7XWRf//RqK+uPKAQp+dU5rJBHoy3yopjXs5NWDk5to59cxylwICFPtU2oWwjMfLTfk4ej+uOLpSObX5GydJcmvX8Kyx/0gGzRNewg+vrlhdwH6e/3D2W1hJmSof8EFLWXWCpZJrHSviWuMr8M5ifK92B3N9WTauwg1+9GNKrVFRDS2hhxfsAb2YUG5YlkzhBMwkCazuTKLSDQ2IeNB6L7d7TDG2kUNtwauHl1BG6c7qG9kldox1Y53tNbr2PsjlL1b0TAeAmXWmqbdJ+VZNpQTmZnpLtm9G9iJjOSNEt+uRAmqFzMAwRHO74mDWWbtXGDdsH7hQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OsT/UPaGOV2cU94fs/Znpb7ITsYn/Nf3DbhI1jkRQsA9CUAs7NeS0zCR6qsmNJvsK+ejILXYe4IKmLAZ2o00u9u58ZPcMcvtw/Zn575c8k65RvfSwwN6fdEIwP1qPJwjK5Rec0LYHk5yhxDAIplwwNPnuZVotiQxnRwR3gRwISr+SATJZhAIEA5C5I7abxzHoXaZPfko6VSgZvOggwsdHJrXKUp8W226Bbvmj7hSuV7p9NWYJajTc6TBU/q9yL8umItSaIN9VShPSGtOOoxzHvAJLRmsG5Y+tvJQZd4j8Tb/76ynPojakdphQ7Du088gRdU3Q0ykvReUFcOug1uW2g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "Cooper, Andrew" <andrew.cooper3@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Pau Monné, Roger <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 31 Jan 2022 10:04:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 30.01.2022 04:17, Tian, Kevin wrote:
>> From: Jan Beulich <jbeulich@xxxxxxxx>
>> Sent: Tuesday, January 11, 2022 12:23 AM
>>
>> In order to be able to insert/remove super-pages we need to allow
>> callers of the walking function to specify at which point to stop the
>> walk.
>>
>> For intel_iommu_lookup_page() integrate the last level access into
>> the main walking function.
>>
>> dma_pte_clear_one() gets only partly adjusted for now: Error handling
>> and order parameter get put in place, but the order parameter remains
>> ignored (just like intel_iommu_map_page()'s order part of the flags).
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> ---
>> I was actually wondering whether it wouldn't make sense to integrate
>> dma_pte_clear_one() into its only caller intel_iommu_unmap_page(), for
>> better symmetry with intel_iommu_map_page().
>
> I think it's the right thing to do. It was there due to multiple callers
> when firstly introduced. But now given only one caller mering it
> with the caller to be symmetry makes sense.
I guess I'll make this a separate change towards the end of this series
now, to save me from some rebasing of other patches.
> with or without that change (given it's simple):
>
> Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
Thanks.
Jan
|
