[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V3 2/2] iommu/arm: Remove code duplication in all IOMMU drivers
- To: Julien Grall <julien@xxxxxxx>
- From: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Date: Fri, 28 Jan 2022 18:08:21 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=66PlUvp9Xke4PZdGPPKolC64NlTZ9JLKBhtaWW3wxGs=; b=luJRfXBEFHudcSb426quTKOQKLxL3Me6cl61kvVe8N6N8r/C8rdwM+P2Jr50UYtq7oNcz1/xP+Mt28RZv+dlAun2frI56ySzVQLRqiQUYiMuQyE1cXX0VmTB5ZTzt1ZgmlUsoItV6IQWMWyPVOkElXHGnzOB+6zXGK223txb1gCoSKeDpO5cmuW+Tyz9avPqfDSp4W8NIkOeoPkLCETL3/uhufz9BNBhSMI2zQ6b1gyKCMg/lTPbXc9HUvMdcKU/Jm1W7cwdpOmxWHcSHUH4Da5y7vxfOlykokqSkxmEkdw58pQAa6RKIga9zb8hd0f7XQTUGUPjPjeRavQr/tjbWA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lLuP4WJhBtc7qQtCJH+/Jqdjhw/M4zJAeBwqUYfdSRSIVB00g7ptcaL/BFljvrBklDXNHRTkgT5CCgdxrrr53DQZzCWHJWe3xQOagUpIcS6E14fLzKeZIdnUkTPoPgAf08DZLpDeE0t+wFztGmLk3ECvfxFSTsRLh1j0HmPAB3FbMey+H1u9wldN5TgpD+TxQN6O8SN9OAfJrU6XzkiOToupBBTlgmSzBVwd5RPURnLOxsHRywYwpnKGnsWDgm5Xns+NmM1rrwVUssoG6erppZAk05g8dv3Gdrr87LxXm4IkgrQfv55gF9RZyZOuTiqklpQ7KYziVVbAmy3Ds28H7w==
- Cc: Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>, Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- Delivery-date: Fri, 28 Jan 2022 18:08:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYE7f+bZ++2ph9sECkyhNAfkn036x3SlsAgAFyBgA=
- Thread-topic: [PATCH V3 2/2] iommu/arm: Remove code duplication in all IOMMU drivers
Hi Julien,
Julien Grall <julien@xxxxxxx> writes:
> Hi,
>
> On 27/01/2022 19:55, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
>> All IOMMU drivers on Arm perform almost the same generic actions in
>> hwdom_init callback. Move this code to common arch_iommu_hwdom_init()
>> in order to get rid of code duplication.
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
>> Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
>> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
>
> IMO, the reviewed-by tags should have been dropped with the changes
> you made. So I would like both reviewer to confirm they are happy with
> the change.
Yep, I'm still fine with this:
Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
--
Volodymyr Babchuk at EPAM
|
