[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v9 08/30] build: fix enforce unique symbols for recent clang version
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 27 Jan 2022 16:57:20 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FKgbRvQCixbeZjZFUvP4FhD/a0fIyYo+VXIWTBUenJA=; b=bW8Pm2wBFZuJK8Bw6ubhbXy+ojpziQJUsqOHy9PycI8aPrsdZkFYn+SMgiD9zGsodVoiJ+TwtpKoqmtGhyHC5N022X/uqrv+Sx5scROLfxAgk7HWxD1fn9E2fwDzsExpMjNtzTou5UWXUDc7nI3SyIecfsc5JEYNxYHUvJUtOQuVgTOYaryJ2TJNrB+1fSP/1k85w5RGSUZ4oGdxZePNHEjneIeBm7VsnEJ3LKv+dDZkaDQjZJ4KAG1RGTf5QHlX8JdJ3PyoqKuwK9u/B8zVipXOh8SITI33EFCRluvvGZYRSvZUj3Vme234st6Zy2xeoxBsrnLn1kKZycnL71HfQQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ctxoE/v6SlinSiTXdzyh58ZP/RrcVOY5wtb0PNF0Iv4Y/xyGDZbuF9xDVxYjMpmsTH8biWbiibjkKyfM/RBn3XRUDKHKuTcFpxE8H7iVDt9JA7/Ji4PoISo05TW1kqef8LVOI+qCGxzTNzQVnjGIz6waS3cg8vQUNTRaIh0XYLwv+yFAZTI9FGe6G00kMUulsJ8i8el5o71iIeQgWmoWN4myxxkwUvj07u82j8PyIIyPBccva6un+9VcZxf15y/4+Eqn9u5Jfriput/6WrWpng+4LADKfQ4IXDDH5QjCAHuWAYQiBUBJH5OQ0lGynK4IJrHrRnb4Sdm+xDdS6pF3ug==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 27 Jan 2022 15:57:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25.01.2022 12:00, Anthony PERARD wrote:
> clang 6.0 and newer behave like gcc in regards for the FILE symbol, so
> only the filename rather than the full path to the source file.
>
> clang 3.8.1-24 (in our debian:stretch container) and 3.5.0-10
> (in our debian:jessie container) do store the full path to the source
> file in the FILE symbol.
>
> Also, based on commit 81ecb38b83 ("build: provide option to
> disambiguate symbol names"), which were using clang 5, the change of
> behavior likely happened in clang 6.0.
>
> This means that we also need to check clang version to figure out
> which command we need to use to redefine symbol.
>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
The "likely" in the description still worries me some. Roger, would
you happen to know, or know of a way to find out for sure ("sure"
not meaning to exclude the usual risk associated with version
number checks)?
Jan
|
