[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH 15/37] xen/x86: rename acpi_scan_nodes to numa_scan_nodes


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Wei Chen <Wei.Chen@xxxxxxx>
  • Date: Thu, 27 Jan 2022 08:14:29 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oCEc+zKkmkqTCdCnziPZ+ZQWzgH2zfHYlC70jkur7JE=; b=kpmIPviHHEzAu6Li3/T1QAuNAZc1RLo0yaW3Tz7EW6igS46Hh4OcVHYxMhqaUpzSGQ7B0qBIlXzk0V8jLmLk45Rw04+enrYaeZ+C258Q3OhunUyMDdWndJcWDPeMPFUaO27+HAEyPcOHtGOxUP7a4A0Ldn9itQNUNlXRht6IdTzXgYdArD2/ankMQzhOUYVSVLLOtiBVGImUXiFNbyTh+jv6oYBW7OQzx9Z5OSyhkNLE3AELNG+VFYwcBYP27DHAwVCAIXd3D3H+4TI4kj1vSatICyiSea5XbbrcQQGDa5Lt+XvKM5/Sf7rzx0nIwzXAZMZkjD/XhpvCcYP3f1eM9g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b0EqQt8RUsSu8VgzdL5+WAQiB5BwAm3AZOJunmEOp+N/Daias6q8BEYnymyCUnEMLHAkE2spkRvAqK3YutHplS966P/QcfYdZz9w3IWowRpFDAv3Gxz8fqk20ou3DtAokGlNuhBeW59AcOGbZCiaFwMGBWV/U8vJRoSs4vM8FZAxZlETUHOof138tppb5grYHBiWojEHmOOMNeAQu/SyKiw9G7h7Tn5RSVBFTN5fy1bODHgVozpiXDLigvWlAuYSEwN9lNOM+J1+a070IpVQ9G7Jo4ADhqrRToeAAGsMalMvNAPXoLC0WePHjoGM0pbI8lZ2unhQNyc2seoNCmPJvg==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>
  • Delivery-date: Thu, 27 Jan 2022 08:14:55 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHXsHMZzHhoPQlfrk6ax6b2f3dKq6x0SK8AgAMBXcA=
  • Thread-topic: [PATCH 15/37] xen/x86: rename acpi_scan_nodes to numa_scan_nodes

Hi Jan,

> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: 2022年1月25日 18:18
> To: Wei Chen <Wei.Chen@xxxxxxx>
> Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx; sstabellini@xxxxxxxxxx; julien@xxxxxxx
> Subject: Re: [PATCH 15/37] xen/x86: rename acpi_scan_nodes to
> numa_scan_nodes
> 
> On 23.09.2021 14:02, Wei Chen wrote:
> > --- a/xen/arch/x86/srat.c
> > +++ b/xen/arch/x86/srat.c
> > @@ -512,7 +512,7 @@ void __init srat_parse_regions(paddr_t addr)
> >  }
> >
> >  /* Use the information discovered above to actually set up the nodes.
> */
> > -int __init acpi_scan_nodes(paddr_t start, paddr_t end)
> > +int __init numa_scan_nodes(paddr_t start, paddr_t end)
> >  {
> >     int i;
> >     nodemask_t all_nodes_parsed;
> > @@ -547,7 +547,7 @@ int __init acpi_scan_nodes(paddr_t start, paddr_t
> end)
> >             paddr_t size = nodes[i].end - nodes[i].start;
> >             if ( size == 0 )
> >                     printk(KERN_WARNING "SRAT: Node %u has no memory. "
> > -                          "BIOS Bug or mis-configured hardware?\n", i);
> > +                          "Firmware Bug or mis-configured hardware?\n", i);
> 
> Besides the prior theme of in-place renames not making clear why the
> rename is being done (by deferring to future patches then moving the
> code) I'm puzzled by you replacing "BIOS" but leaving "SRAT" in place.
> 

The reason is the same as I said in previous patch. At that time, I
want to treat device tree as another static resource table. I would change
"SRAT" to "NUMA". And I will try to merge this rename patch with the
actual affected patch.

> Jan


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.