[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/8] x86/msr: Fix migration compatibility issue with MSR_SPEC_CTRL


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 26 Jan 2022 17:33:40 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Pkt7X+vVR2ncP7GWcqKAjQtAV9rV5o+GQb71TO8x9vw=; b=WPQShcIKediHjcdnuDH1LZ7lPg176NlOfjQqzY/Co5KIr2e3huwMwfEwcQ91+PjtqHjzAUP+CCgm21DHKAm0wNNukewG3O33rPDx8AY2e6dX1/zVD9xdL41PpzT6tUuomQKbLlRU0+bETmepexcqdNrMsDWf67p0NBPRtyFOiBnWNjE04uS3n1k8t+uiFUPCuZalddzw8sCxvuE/CyNsNWAasPr4IJQ6hKPEcm71A8PmN6NCY53Y9c95vNI5ASvTxOfUA3l0dkNN8JeGMR0g/HdnvMynbk7YFu/gElKh233hn7cBrAgiZdyDgJUcW22nCOPRgEIDPj5DPqJPUxVIlA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SDBaAWtzG4QkwJ8Yad/lsF/A2wwmzm5BkgqGvoCB5vEVYCTvgh1r6A0pv85h2iROvUL+FVnSSqKFjOWKb3jXiZdgrGsuHCKiUPd1yRy4l9mmroXn2xjdQdn+/sU8RV4WpXDjobk//evr/ZTGpUXPBeULeozliwAqxPgVtFw0kyB0EjgSlOY6jqUgVFBJ/xFQqDkk+U+a5O1cEcPvzNSfY5bsdaVIWtcBPRAWESp87zcTJ233sh0/sat5LEAQA2jUe7ehEO79mVh8BGeub+IJpsiowJQ4m+AMx4WlL+zVoqOT3GJNMKXKHKJ2ElsDCpua3b8/hW8rC5atvO2uY78yCw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 26 Jan 2022 16:33:52 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 26.01.2022 09:44, Andrew Cooper wrote:
> This bug existed in early in 2018 between MSR_SPEC_CTRL arriving in microcode,
> and SSBD arriving a few months later.  It went unnoticed presumably because
> everyone was busy rebooting everything.
> 
> The same bug will reappear when adding PSFD support.
> 
> Clamp the guest MSR_SPEC_CTRL value to that permitted by CPUID on migrate.
> The guest is already playing with reserved bits at this point, and clamping
> the value will prevent a migration to a less capable host from failing.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.