[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/pvh: print dom0 memory map


  • To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 24 Jan 2022 17:03:49 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xTSzirHaUNmathUw7AmBJDZNEvpO5kRosWk6ErJIvjI=; b=A9rikqPIdYG9IY5gqdLn2FrDxVi3QZMsgxOmvJKzLDFNxXS8oreMgLAGGHxfCk+ZxstMQxhby80047DL8VnzqljwD6RRNPl1CAINxLadFbp2Rdwgsx0hD7Qa6eBH6NHuAhGUY+N8Buq5t2FZPZpRTAjawG6jglfH6xCzAo7CwP+mEuxoRD0K979uFsAzpQUVTwyNcq9L2LbII6tSPOr+Nei58UXJdYvnYI/Vj39sQLhqI5HZOAXaPavhxixROioz9TzS4E0JWVTjtOWFeDQ9Yfj+btYbcW2ld5nmiis0S/WWrgQfACpkTThULRYlaYurmmD63+hO7yGNdc13y3VcvQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=arZNzELJa2PDIlbLjB46Dqm0a3M5EtNv34xxxqANVj5bOcJu42HPO2EEJVE/UvLqkHUuQirx5rZ7a02WGQCFKrXjVrzu2PhrQDU6TeGYM0kEJsD9Fi1HgSFXU/zfjfh4W/VJ6xBPc4oU+PTZDdhTI0TmhVDmEJdyf6GjLJG/XaC2Dtdd5Zx8quGimFRX2JhEDgZIxiyAA01AOdorZFzQvb4kUDUzTNk2yeJymvwxQHDVvAd424weQdG94cZEDi4/B1pLQLM3r+QoM3OZhgwymN3pE28sRCHHAKms50wD8pti6G4zGGtPq3tprQsSj62M9c1OXY0LYdQEZzF1oPBYaw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 24 Jan 2022 16:03:57 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 24.01.2022 16:51, Roger Pau Monne wrote:
> I find it useful for debugging certain issues to have the memory map
> dom0 is using, so print it when using `dom0=verbose` on the command
> line.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
with one further request:

> --- a/xen/arch/x86/e820.c
> +++ b/xen/arch/x86/e820.c
> @@ -88,7 +88,7 @@ static void __init add_memory_region(unsigned long long 
> start,
>      e820.nr_map++;
>  }
>  
> -static void __init print_e820_memory_map(struct e820entry *map, unsigned int 
> entries)
> +void __init print_e820_memory_map(struct e820entry *map, unsigned int 
> entries)

While making this accessible from the outside, could you please
make "map" pointer-to-const?

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.