Re: [PATCH v4] xen/arm: Allow QEMU platform to be built with GICv2

[Bertrand Marquis <Bertrand.Marquis@xxxxxxx>]

Hi,

> On 17 Jan 2022, at 14:15, Julien Grall <julien@xxxxxxx> wrote:
> 
> Hi,
> 
> On 17/01/2022 10:40, Dongjiu Geng wrote:
>> It turns out that QEMU has been supporting GICv2 virtualization since
>> v3.1.0. So remove the dependencies on GICv3.
> 
> 
> Technically, the current form of CONFIG_QEMU allows the same binary to boot 
> on QEMU with GICv2 or GICv3.
> 
>> If we want to use GICv3,
>> we can select the QEMU_LEGACY configuration.
> 
> AFAIK, GICv3 is not a legacy feature... So it feels a bit odd to name it like 
> that (see more below).
> 
>> Signed-off-by: Dongjiu Geng <gengdongjiu1@xxxxxxxxx>
>> ---
>>  xen/arch/arm/platforms/Kconfig | 10 +++++++++-
>>  1 file changed, 9 insertions(+), 1 deletion(-)
>> diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig
>> index c93a6b2756..41e82a42ee 100644
>> --- a/xen/arch/arm/platforms/Kconfig
>> +++ b/xen/arch/arm/platforms/Kconfig
>> @@ -13,7 +13,15 @@ config ALL_PLAT
>>      automatically select any of the related drivers.
>>    config QEMU
>> -    bool "QEMU aarch virt machine support"
>> +    bool "QEMU aarch virt machine support >= v3.1.0"
> 
> This is a bit misleading. A user may select this thinking that this will 
> select GICv3. However, this will not.
> 
> This also raises the question of what is the default GIC version in QEMU 
> (i.e. if you don't pass anything on the command line)? If this is GICv3, then 
> I am afraid that this patch would be a no-go for me.
> 
> Looking at overall discussion, you seem to push the patch only to allow 
> building a tiny Xen for QEMU and the new vGIC.
> 
> The default Xen (i.e. make defconfig) will also work on QEMU. Given that the 
> new vGIC is a still in development, I am seriously considering to say that if 
> you want to try it then you have to use the default configuration.
> 
> @Dongjiu, is there any reason why you want to use the tiny QEMU config rather 
> than the default configuration?
> 
> @Bertrand, @Stefano, what do you think?

I do think that the new Legacy option is very misleading and users will tend to 
select Qemu instead of the legacy one where having GICv3 makes more sense.
Using the new VGIC which is unsupported is not a standard use case so maybe it 
would make more sense to create a specific Qemu entry for GICv2 using new VGIC 
instead and keep the default as is.
To sum up I am no in favour of a solution changing the existing QEMU. A 
solution creating a new one for the wanted use case would be better for me.

Cheers
Bertrand

> 
> Cheers,
> 
> -- 
> Julien Grall