[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4] xen/arm: Allow QEMU platform to be built with GICv2
- To: Dongjiu Geng <gengdongjiu1@xxxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Mon, 17 Jan 2022 09:00:03 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FsZfkdvA8kBRNbmaABERT3xwEZUZOrcVcPJhY73joag=; b=RoJ2qxyoKpsy06vlwlYwxIR0mP59MLLQxtDYAJzHZfeAl54hf9iFcLdnkLUDVVLcUZpwCGzB1lZCzyC3Yh0OsykdL8WPB9KUpED5NUwzFj858dvDYBrQQUoRxGrUic3Bx2Jm+rEblFGeDyOZOvAxrjxDvG1IEHZh+fIN8mJ0o0ViuYTabEx9huKwZ6D5tgLilhhe5xfc/0WCl+gUxV7Ikx2zwErw6vhbbH+ONypdAb75l68VCKIUnxwvH4FsYL0GyW0aMtcbTgpacZQClfxgRJbFFPxo0OXfD0+xcQVD79yT3946TIdqBnj82eU4KYi2YrUDlU9rWmkK+N0mJ8IZoA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j2uSh5vdyFgQPkjUs3B6EbX0buIG+v2lQLJ3RO1PiKAHQA5DwjQDeUk0DmKpawcUFBqQtkQ9ZUgv6s83ydlk9gYf68UVv7lZH+ZGHwKACDPUSLkyKXfreG9iZzw0qiPkq0MEE6IlIDZQT6QGGYutjRvXur0lTyDkCl+PvtgVVGkSoGASsQyxDTOlpQL5SD6cyh6nyBvmeU0m8JJwuM5QozTKxpXr64ruQg/5VCByLpkvcNbmihYPXCL66Yski2cSg5uTigg7xT69FQbkWga64L0BqfBIrZVtoHRxpYtPLmfYs8snuboTa+D/5evUmx7lD3FyYyyovn6Z5uO3go28vA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, "Volodymyr_Babchuk@xxxxxxxx" <Volodymyr_Babchuk@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 17 Jan 2022 09:00:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYC20k2h7y374id02KJynAohV9hqxm6mCA
- Thread-topic: [PATCH v4] xen/arm: Allow QEMU platform to be built with GICv2
Hi,
> On 17 Jan 2022, at 06:40, Dongjiu Geng <gengdongjiu1@xxxxxxxxx> wrote:
>
> It turns out that QEMU has been supporting GICv2 virtualization since
> v3.1.0. So remove the dependencies on GICv3. If we want to use GICv3,
> we can select the QEMU_LEGACY configuration.
I am bit puzzled by this change introducing a legacy option actually selecting
the newest GIC interface.
Can’t we do the opposite and introduce a QEMU_GICV2 instead ?
Also why do we need to remove gic-v3 support ? The code should actually select
which gic to use depending on the device tree.
Regards
Bertrand
>
> Signed-off-by: Dongjiu Geng <gengdongjiu1@xxxxxxxxx>
> ---
> xen/arch/arm/platforms/Kconfig | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig
> index c93a6b2756..41e82a42ee 100644
> --- a/xen/arch/arm/platforms/Kconfig
> +++ b/xen/arch/arm/platforms/Kconfig
> @@ -13,7 +13,15 @@ config ALL_PLAT
> automatically select any of the related drivers.
>
> config QEMU
> - bool "QEMU aarch virt machine support"
> + bool "QEMU aarch virt machine support >= v3.1.0"
> + depends on ARM_64
> + select HAS_PL011
> + ---help---
> + Enable all the required drivers for QEMU aarch64 virt emulated
> + machine.
> +
> +config QEMU_LEGACY
> + bool "QEMU aarch virt machine support < v3.1.0"
> depends on ARM_64
> select GICV3
> select HAS_PL011
> --
> 2.25.1
>
|
