[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/hvm: reserve another HVM context save record ID for Amazon


  • To: David Vrabel <dvrabel@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 14 Jan 2022 08:08:48 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gz9lzFsJ/c+Lbn0wg90hNQLe0EY2iriQLbKsLo3V/EE=; b=gNtVnbOP5GSlfxfiFuAemoO+DuyAXJD0tIB6A/8pl0aYwJBxxu5ubkd1YiMKo/ti2YwtgXNfOn7YlYUmr0EJuBGAC+PGwNxT/zqjab+Dh7ZFrQUFHra86BE4v/bMwVX8ZzqwLIUpY0iVIk8INggUntjj3+sLuSXcHkSbqYHNo/Q+GO417gayVXOaEdQ9Gu7cuprfoBvzy4gg3aaTxKrLMqfpFd/quAiUkoU0OyYhUVVYhGPNQc+koPk2Fr4cXv6YZR/u2BR/P/XV1K9FC3/saXpdEJU/hWPQNbA9FUXNUFbEKdmnJTSWI5epzrrJ7G8jPCfuoMGQ0E+mGmhj1m5z+g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iXQiB9GEcY0HbKMeAWeS74e7ud/S4hA4cY08OKZY/FCZw7qWqvYC4IXFkDzgX/qDb8DHIqe29oSMKrmU6jSm36pVo8MK1NiLdSgys0JhbualRyj9IDro7MXId6onfjDcx+p6HrbPaSudAmFhtvzm+yx29NE9TjrIMwOQsstw5IBUj+dOmgw8nFtiBMo95JtMOBwKJnesV7ootgfBXFVZw3/gP6Cfa8CY17rf7QyLKp7GE9NxviMt+EWYo7vP0Am14xMHPxD+8tdjtDm6CSzYWM914Do/2FuBI/H18kL2i5YDIR4xiJTQPwWiIDkXnnxN1mLZNpTTCRXmNdwASlV7rA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: David Vrabel <dvrabel@xxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Paul Durrant <paul@xxxxxxx>
  • Delivery-date: Fri, 14 Jan 2022 07:09:06 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 07.01.2022 13:55, David Vrabel wrote:
> Amazon's guest transparent live migration work needs another save
> record (for event channel upcall vectors). Reserve another HVM context
> save record ID for this.

I have to admit that I have reservations: I didn't really like seeing
the original range getting reserved. Even less so I'd like to see
extensions / further such reservations. The more that iirc the
original reservation was accepted based on a (perhaps vague) promise
of the respective uses actually getting upstreamed. Yet that hasn't
happened (nor even started to happen) in slightly over 2 years time,
iirc.

What I could see as a compromise is to have, say, vendor ranges
higher up in number space.

Jan

> Signed-off-by: David Vrabel <dvrabel@xxxxxxxxxxxx>
> ---
> I've added it to the end, keeping the unused ID at 21.
> ---
>  xen/include/public/arch-x86/hvm/save.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/include/public/arch-x86/hvm/save.h 
> b/xen/include/public/arch-x86/hvm/save.h
> index 773a380bc2..2de3dfd9bb 100644
> --- a/xen/include/public/arch-x86/hvm/save.h
> +++ b/xen/include/public/arch-x86/hvm/save.h
> @@ -641,7 +641,7 @@ struct hvm_msr {
>  
>  #define CPU_MSR_CODE  20
>  
> -/* Range 22 - 34 (inclusive) reserved for Amazon */
> +/* Range 22 - 35 (inclusive) reserved for Amazon */
>  
>  /*
>   * Largest type-code in use




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.