[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v2 2/3] tools/libs/gnttab: decouple more from mini-os
On 12/01/2022 07:27, Juergen Gross wrote: > On 11.01.22 21:08, Andrew Cooper wrote: > >> The least bad way I can think of doing this would be to leave void >> minios_gnttab_close_fd(int fd) exactly as it was, and instead of >> converting it's use here, use a separate static function straight away >> for the file ops. (Will be necessary anyway if you like my suggestion >> of passing file too). Then in the whole function in "tools/libs: final >> cleanup making mini-os callbacks static", rather than just making it >> static. > > I can change it if you really want. Well, it will happen as a natural side effect of passing file* rather than fd, but I do think it is a safer course of action. ~Andrew
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |