[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v2 03/12] mini-os: use alloc_file_type() and get_file_from_fd() in xs
On 12/01/2022 07:52, Juergen Gross wrote: > On 11.01.22 21:21, Andrew Cooper wrote: >> On 11/01/2022 15:12, Juergen Gross wrote: >>> void xs_daemon_close(struct xs_handle *h) >>> { >>> - int fd = _xs_fileno(h); >>> - struct xenbus_event *event, *next; >>> - for (event = files[fd].dev; event; event = next) >>> - { >>> - next = event->next; >>> - free(event); >>> - } >>> + close(_xs_fileno(h)); >>> } >> >> You've deleted the sole caller of xs_daemon_close() from the main >> close() function. >> >> That said, I'm very confused, because nothing in minios declares it. >> The declaration appears to come from xenstore.h, which is clearly >> included unconditionally (when it ought not to be), but libxenstore also >> defines the function too... > I already thought of restructuring this mess. > > lib/xs.c is the Mini-OS variant of libxenstore, and as such it shares > quite some code with libxenstore. > > So the correct thing to do would be to split libxenstore into a common > part and a posix/Mini-OS part, drop lib/xs.c, and use the library in > Mini-OS instead. > > But this should be done in a separate series. Sounds like a plan. ~Andrew
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |