[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v2 16/18] mini-os: reset file type in close() in one place only
On 11/01/2022 14:58, Juergen Gross wrote: > diff --git a/lib/sys.c b/lib/sys.c > index 0e6fe5d..323a7cd 100644 > --- a/lib/sys.c > +++ b/lib/sys.c > @@ -424,87 +424,82 @@ int fsync(int fd) { > > int close(int fd) > { > + int res = 0; > + > printk("close(%d)\n", fd); > switch (files[fd].type) { I know this bug is pre-existing, but the libc close() really ought to sanity check fd before blindly indexing files[] with it. I'd tentatively suggest that you want one extra goto from here, into wherever the EBADF logic ends up, and it's probably worth including in this patch. ~Andrew
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |