Re: [PATCH] build: fix make distclean

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Mon, Jan 10, 2022 at 10:04:56AM +0100, Juergen Gross wrote:
> On 10.01.22 09:42, Jan Beulich wrote:
> > On 09.01.2022 11:01, Juergen Gross wrote:
> > > "make distclean" will complain that "-c" is no supported flag for make.
> > > 
> > > Fix that by using "-C".
> > > 
> > > The error has been present for a long time, but it was uncovered only
> > > recently.
> > 
> > And that's because the rule simply was unreachable before? Or it was
> > reachable, but only via special (non-default) $(MAKE) invocations?
> 
> I just hit the bug during a top level "make distclean" and looked which
> commit introduced it. As it was really old, I looked for a more recent
> commit which could trigger the bug and found the rather recent one,
> making me believe that the wrong rule was never reached (other than by
> a "make" in the local directory of that rule).
> 
> I didn't spend more time on digging out whether the problem could have
> happened in other cases, too.
> 
> > > Fixes: 2400a9a365c5619 ("tools/debugger: Allow make to recurse into 
> > > debugger/")
> > > Fixes: f9c9b127753e9ed ("tools: fix make distclean")
> > 
> > To distinguish from this commit's title and to also identify the affected
> > component, how about having "gdbsx" somewhere in the subject? (To be
> > honest, with this title I wouldn't even have expected the issue is in the
> > tool stack part of the tree.)
> 
> Hmm, yes, the prefix could be changed to "tools/debugger".

With that:
Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks,

-- 
Anthony PERARD