Re: [PATCH v5 05/12] libs/guest: allow fetching a specific MSR entry from a cpu policy

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Mon, Dec 06, 2021 at 04:27:25PM +0100, Jan Beulich wrote:
> On 29.11.2021 16:33, Roger Pau Monne wrote:
> > --- a/tools/libs/guest/xg_cpuid_x86.c
> > +++ b/tools/libs/guest/xg_cpuid_x86.c
> > @@ -878,6 +878,26 @@ int xc_cpu_policy_get_cpuid(xc_interface *xch, const 
> > xc_cpu_policy_t *policy,
> >      return 0;
> >  }
> >  
> > +int xc_cpu_policy_get_msr(xc_interface *xch, const xc_cpu_policy_t *policy,
> > +                          uint32_t msr, xen_msr_entry_t *out)
> > +{
> > +    const uint64_t *val;
> > +
> > +    *out = (xen_msr_entry_t){};
> 
> Unless there's a specific reason for the divergence, this just-in-
> case initialization should imo be consistently there (or absent)
> in both the MSR and the CPUID function.

Right - will add the initialization to the CPUID function.

Thanks, Roger.