[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tools/libs/light: set video_mem for PVH guests
- To: Andrew Cooper <amc96@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 11 Jan 2022 12:26:24 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ULfAFvYIo4kefH6stSr6XVisjycs3F2wp0Q1rb6HjZ8=; b=l6KUYXBeH9Ag5saj7gE7lnDsIKzygUWLez3qFiVkryRslkvRnIZEWn216nb+dLSSmF46WgWm8xJzH4pu5s1eUBEAePYGCaa6527WU5ax3WjXewpQaYsZpUBsYNZD9lCJZAMJuOXSj2rvCFAyRWljf6OpbhBLOqXlySsvV9RZrOuDBRad3cTDSnuHiizkiCQml9/CWmqRFl+2QJ47p8RxCBxJafHuy97wc4bs6ddyeqhLl9rHs7vt7sauDsqQkmqEqgRM2tGqmm1bcyN7agKvdSYnDIVOP+3cRDbwSOwYHDiEIMagtbU21gmqTNRHjL0N25eWSP4Xz8VOuYINQFMZiA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AemvOUCZnDcGQJiYgdphgxLLUu0JZt+cC47+MIiUoWwWhx19Lw3tvFhJtEl/KODZPRnQ962Nkl+Sy3+U/OSrnDdtriGCaGlXup9IdeIPQf1T2fl0uqJTJsFonCO/twop1GQ3OqCSoE0JJ9AWkmpUGg0EMR6iym89uAGbsqRcgWj2otnHTj1EDrrhXs1/SB3Nb4J/r0CoaqLQEe11yQqDe/Mi1qi2BMWXKGCdIu0sYSv3dyVqZnUviCnZF5Abfmaxx5XvYF14Z+zuDJUjwbBNrgO2sj0WXZ3IWza1vgvVjBzTsTROQDHVLN91I5QcNSNKj56MnDDiCinu/osR3V9WKQ==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Juergen Gross <jgross@xxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- Delivery-date: Tue, 11 Jan 2022 11:26:43 +0000
- Ironport-data: A9a23:O8PU/KBOmkhHlhVW/7Tkw5YqxClBgxIJ4kV8jS/XYbTApGkr0DIAy mceDG3SbPmON2L8fI9+O46yphhTvcXUnddgQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WL6s1hxZH1c+En940Es7wobVv6Yz6TSHK1LV0 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/pDWjv88t9 O90u8aeSSs3ArbQpf0yekwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHf6auYAIh25YasZmWuSBX ccTbCFVSU6YQDZoHlMYVqo1g7L97pX4W2IB8w/EzUYt2EDS0w5ZwLXrKMDSeNGBWYNShEnwj n3C13T0BFcdLtP34TiP/2+oh+TPtTjmQ49UH7q9ntZjhVbCmEQIEhYYE122vZGRiEGkXMlEA 1cJ4Sdopq83nGS7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsc9JaQIV47olsH2Vsj wLX2YOybdByjFGLYV2d3JeL8Q+IACZPA28uexMfUTYczPC29enfkSnzZtpkFae0iPj8Fjfx3 y2GoUACulkDsSIY//7lpA6a2lpAsrCMF1dovVuPAgpJ+yskPNbNWmC+1bTMAR+sxq69R0LJg nULktP2AAsmXcDUz3zlrAng8diUCxe53N/03AYH83oJrW3FF5ufkWZ4umoWyKBBaJdsRNMRS BWP0T69HbcKVJdQUYd5YpiqF+MhxrX6GNLuW5j8N4QSO8gtLFbWpHozPSZ8OlwBdmB2ysnT3 r/BIK6R4YsyU/w7nFJauc9AuVPU+szO7TyKHs2qp/hW+bGfeGSUWd843KimNYgEAFe/iFyNq b53bpLSoz0GCbGWSnSJreY7cA5bRVBmVcGeg5EGLYarf1s5cFzN/teMm9vNjaQ/wfQM/goJl 1ngMnJlJK3X3iyYeV7UOyE6ONsCn/9X9BoGAMDlBn7xs1ALaoez9qYPMZwxeLgs7ut4yvBoC fICfq297j5nE1wrIhwRMsvwqpJMbhOuiV7cNiapemFnLZVhWxbI6pnveQ62rHsCCS++tM0fp by811yEHcpfFlo6VMuGOuiyy16RvGQGnL4gVUX/PdQOKl7n95JnKnKtg6Zvcd0MMxjK2hCTy x2SXUUDveDIroJsqIvJiKmIop2HCex7GkYGTWDX4azvbXvR/3a5wJ8GW+GNJGiPWGTx8aSkR ONU0/Cjb6FXwAcU69JxSu85w7g/6t3jo65h4j5lRHibPU62Dr5AI2Wd2ZUdvKN62bIE6xC9X ViC+4cGNOzRat/lClMYOCEscv+HiaMPgjDX4Pk4fBf66Stw8ObVWEleJUDR2ilULb8zO4I52 +Yx/sUR7lXn2BYtN9+HiAFS9niNcSNcA/l26MlCDd+5kBcvx3FDfYfYW33/75y4YtlRNlUnf 22Pj63YirUAnkfPfhLfz5QWMTaxUXjWhC138Q==
- Ironport-hdrordr: A9a23:DUhy7am8VnMWq8Le9Dj88V4Af03pDfO0imdD5ihNYBxZY6Wkfp +V88jzhCWZtN9OYhwdcLC7WZVpQRvnhPlICK0qTM2ftW7dyRaVxeBZnPDfKljbdREWmdQtt5 uIH5IObeEYSGIK8foSgzPIYurIouP3iZxA7N22pxwGLXAIV0gj1XYANu/yKDwJeOAsP+teKH Pz3Lsim9L2Ek5nEfhTS0N1FNTrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S yd+jaJq5mLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e O86SsIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNUQHIvsEobgcXgrS6kImst05+r lMxXilu51eCg6FtDjh5vDTPisa2HackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu 9zF8vRjcwmPm9yV0qp/lWH/ebcHUjaRny9Mwo/U42uonRrdUlCvgolLJd1pAZEyHo/I6M0kN gsfJ4Y0I2mdfVmHp6VMt1xNfdfOla9MS4kD1jiU2gPNJt3ck4l+KSHqInc2omRCek1Jd0J6d P8bG8=
- Ironport-sdr: VlJ/eW+4RAHsByqYae5WlYo7pj4tLT24hatPzg+gyqL0Yh585lW1Nkg82Hpx1/j8tcsuFMpKUN Ioh28oUfW/7N9C53k1+IcUXWTzIZW1sED86I5CI22m0ejUZEEmpdlFeJt+g2R+Vpj4knDoR6wu QrsbQq6uVA/BCRJnl9eHfOo0kL+jB3kpVbW+e7yJyg3OgfotdB7AgEHXazbX5MPVFyKW8QpXNL KNKFF/TxITNtcg8DCJC/kL6LLF2ao37tiZgGwzEVPLl6AuwE4Oo4dtIoEcYA47yQLxTN15D4rL 6zrvUByMJAC1E0gW2eUktrr/
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Dec 08, 2021 at 02:00:48PM +0000, Andrew Cooper wrote:
> On 03/12/2021 07:30, Juergen Gross wrote:
> > The size of the video memory of PVH guests should be set to 0 in case
> > no value has been specified.
> >
> > Doing not so will leave it to be -1, resulting in an additional 1 kB
> > of RAM being advertised in the memory map (here the output of a PVH
> > Mini-OS boot with 16 MB of RAM assigned):
> >
> > Memory map:
> > 000000000000-0000010003ff: RAM
> > 0000feff8000-0000feffffff: Reserved
> > 0000fc008000-0000fc00803f: ACPI
> > 0000fc000000-0000fc000fff: ACPI
> > 0000fc001000-0000fc007fff: ACPI
>
> The patch itself is fine, but some further observations based on the
> memory map alone.
>
> It is rude to provide an unsorted memory map.
>
> The LAPIC range is required to be reserved by the ACPI spec, missing
> here. Conversely, it's unclear what the reserved region is trying to
> describe.
IIRC those are the special pages used by Xen console, store, identity
page tables, ioreq...
> Of the 3 ACPI ranges, one is RSDP (the first 64 bytes), one is the info
> block (4k), and one is the ACPI tables themselves.
>
> RSDP really ought to be merged into the same block as the rest of the
> ACPI tables.
>
> The info block must not be marked ACPI reclaimable RAM, because it is
> referenced by AML inside the DSDT/etc. This is a very serious issue if
> the OS actually exercises its right to reclaim those regions and use
> them as RAM.
There's no DSDT on PVH, but I'm unsure whether it's also marked as
reclaimable RAM on HVM which does have a DSDT. Last two blocks should
likely be ACPI NVS I assume.
Thanks, Roger.
|
