Re: [PATCH 02/15] mini-os: makes file.read bool and move it ahead of device specific part

[Juergen Gross <jgross@xxxxxxxx>]

On 09.01.22 11:20, Samuel Thibault wrote:
> Juergen Gross, le dim. 09 janv. 2022 07:12:32 +0100, a ecrit:
> > On 09.01.22 02:21, Samuel Thibault wrote:
> > > Samuel Thibault, le dim. 09 janv. 2022 02:18:44 +0100, a ecrit:
> > > > Juergen Gross, le jeu. 06 janv. 2022 12:57:28 +0100, a ecrit:
> > > > > The read member of struct file should be bool.
> > > > >
> > > > > In order to have the device specific part at the end of the structure
> > > > > move "read" ahead of that.
> > > > >
> > > > > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> > > > Reviewed-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
> > > Mmm, but tools/libs/evtchn/minios.c needs updating, doesn't it?
> > It will be, but assigning 1 to a bool is just fine.
> Yes but it's moved in the structure.
It needs recompiling, but no change. Its still file->read.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature