[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCHv2] x86/hvm: add more callback/upcall info to 'I' debug key
On 07/01/2022 13:45, Andrew Cooper wrote: printk("Callback via PCI dev %u INTx %u%s\n", PCI 00:%02x.0 ? Is this correct? If I remember right, the INTx lines are associated with a PCI device, with the function then reporting which line it uses. So Xen neither knows (nor cares) what the function is, so it would be misleading to report it. + hvm_irq->callback_via.pci.dev, + hvm_irq->callback_via.pci.intx, + via_asserted); + break; + + case HVMIRQ_callback_vector: + printk("Callback via vector %u%s\n", + hvm_irq->callback_via.vector, + via_asserted);... here, vectors ought to be 0x%02x. Amongst other things, it makes the priority class instantly readable. I realise this is all a complete mess, but is via_asserted correct for HVMIRQ_callback_vector? It's mismatched between the two, and the best metric that exists is "is pending in IRR". Also, looking at struct hvm_irq, all the callback information is in the wrong structure, because it absolutely shouldn't be duplicated for each GSI. I'm not sure what changes to this patch you want here.. David
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |