[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/5] tools/libxl: Mark pointer args of many functions constant
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Luca Fancellu <luca.fancellu@xxxxxxx>
- Date: Wed, 5 Jan 2022 13:09:57 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cKkQUpGIt52IPiU2Xi1sfOjx+gYHusJi35XBTolNK0g=; b=N1EqYr3pGg8d1WQRziMolqszAN+8YZ4c9eaJBQiVNcGqzvArY93Ci8ETIDe+Eyl8+bm/15R36gEuwWen4CoJAcquMmlHtORUvh8l+l2PPUr2Z1SG72K26aJkAPyP2s9w+1O7bhNaxR+7yZZXCNbMAy4zfPJupOczwxDaLwiwv2E4j18MpHO+vYag58jsbbndFAzbqpKiGBUdM54S0qSfJXpGPzVAJeNMUdJCMjKXuGqtGl+XlUiKJq4pAtK7aw7VRFDKZ2Gmk7ltErzgeJ03F+Jxe8bWzOsTWm9003yDhLyN8izud/nK3ynrssoBtFz+OvHNzVGNEgikeIfh3RO6WA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bCbzBHD/er+Y4pS3hIsyVlnMo+xgnPiNFgE9pmFwRtpGpQj7+ndD/8QsEaJynKyCWLQi+EyYB/extegXRwumaPjfe+wIg/SmQGe1fM+T2rGQPduNG7VJZel6Z8t1qK+G5BaCTVGGICScx2iD4eI8emvHcoUZtAA6NBdm3jsK1U7R7LfVTyJKglfuLRfXh3t2bp2KlubijGvWCIEd/8N4Pi1DdiIf1cIiYPcwKUcKKiRhL6dYvrDoxrYwmv9fYxHXjGJGNW6kph39jlbf5uaPmnMXtxn7VBYvst9/zoFPiv6+jHWZOWayERXt+7F8o/VyCN7URjwYUxI22kQ1v5FTyQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Elliott Mitchell <ehem+xen@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Wed, 05 Jan 2022 13:11:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
> On 5 Jan 2022, at 10:09, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
>
> On Fri, Dec 18, 2020 at 01:37:44PM -0800, Elliott Mitchell wrote:
>> Anything *_is_empty(), *_is_default(), or *_gen_json() is going to be
>> examining the pointed to thing, not modifying it. This potentially
>> results in higher-performance output. This also allows spreading
>> constants further, allowing more checking and security.
>>
>> Signed-off-by: Elliott Mitchell <ehem+xen@xxxxxxx>
>
> This patch doesn't build.
>
> libxl_cpuid.c:510:17: error: conflicting types for
> ‘libxl_cpuid_policy_list_gen_json’
> 510 | yajl_gen_status libxl_cpuid_policy_list_gen_json(yajl_gen hand,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from libxl_internal.h:89,
> from libxl_cpuid.c:15:
>
> /home/sheep/work/xen/tools/libs/light/../../../tools/include/libxl_json.h:30:17:
> note: previous declaration of ‘libxl_cpuid_policy_list_gen_json’ was here
> 30 | yajl_gen_status libxl_cpuid_policy_list_gen_json(yajl_gen hand,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Also we talked about this patch before, in
> https://lore.kernel.org/xen-devel/YImXfc4oaPgWzkeT@perard/
>
> Cheers,
Sorry about that, when I’ve put my R-by I thought it was building, I’ve checked
again and it’s not building for x86_64, arm32 and arm64 looks fine so far.
Cheers,
Luca
>
> --
> Anthony PERARD
>
|
