[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/x86: obtain upper 32 bits of video frame buffer address for Dom0


  • To: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 4 Jan 2022 17:54:59 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dAvsUMNNCWnEhqbX63YX/eBu7PC5VYVcdJG+V7lkZAg=; b=ZvU1fPC+QHVLICyX8hAIQavcLUHOZzCrxX8HukLI5r5AuCxeTMGbOQXdLTyRxz0G8HHDxdWBhXXGc2PY2GfAC+vKqHNLhpT5fBlY8DuHZ+PSAOmgFlPdVo1zXoxd3IF/g5JARP2O/uk7jW8nwIQQxui2XQT52ODDOuIdEOAdSDCpam33SMmvnc3pI5Kc5osOp3ngMPhjBnDZv5TLNw5704Fq8ZU0R9ExCv/k2uBhkFGj1ADO7VBQVcKSUbIGqgTX7uweZ9g2UETND0ooBT9WjqtjKSduddkgUPN1+PG1FoIKxYFRn4koxufaTyuHWTFZyv+PP6jb6kHot5CfsY8UDg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K9QFFanFQoHMIPUEiCe6rZmFvugmh1u/+szyrsdhqvE/G+Yw9GrAAiVVhCBKVuIUMrsLWgjuSjp2+/g5WuJidDkKI3gCMoSVid5UCLmLaa7mQCz6p2GVACkS8vUKvTyiZi/hDY1RjYWh8vgwOH4rOfTM8UwDGZ+8mK52lDpM2kc1YqKVTB0zKcJVxD0IthydR/Zss+XvsQjxrLL7HfPV2NoH2nZAPL+kXuP7lAo6ZNPv9rPoS/72fUvcTsJu7zHOY8pVqgQ4/IPz0R5oSUp5N7csZGKb63uNiDSVK1vAu2MjSCGObBNWK4qQVuLTKZrQNnzbRso2bVyELUg399197A==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, lkml <linux-kernel@xxxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
  • Delivery-date: Tue, 04 Jan 2022 16:55:13 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 04.01.2022 17:50, Boris Ostrovsky wrote:
> 
> On 1/4/22 3:46 AM, Jan Beulich wrote:
>> The hypervisor has been supplying this information for a couple of major
>> releases. Make use of it. The need to set a flag in the capabilities
>> field also points out that the prior setting of that field from the
>> hypervisor interface's gbl_caps one was wrong, so that code gets deleted
>> (there's also no equivalent of this in native boot code).
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>
>> --- a/arch/x86/xen/vga.c
>> +++ b/arch/x86/xen/vga.c
>> @@ -63,13 +63,17 @@ void __init xen_init_vga(const struct do
>>              }
>>   
>>              if (size >= offsetof(struct dom0_vga_console_info,
>> -                                 u.vesa_lfb.gbl_caps)
>> -                + sizeof(info->u.vesa_lfb.gbl_caps))
>> -                    screen_info->capabilities = info->u.vesa_lfb.gbl_caps;
>> -            if (size >= offsetof(struct dom0_vga_console_info,
>>                                   u.vesa_lfb.mode_attrs)
>>                  + sizeof(info->u.vesa_lfb.mode_attrs))
> 
> 
> Do we still need this test? All 4.0+ hypervisors will have mode_attrs.

Perhaps this could also be dropped, but unlike the capabilities part
I'd view this as an unrelated change. Furthermore even a new hypervisor
would be free to omit the field, provided it also sets size low enough.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.