[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/spec-ctrl: Fix default calculation of opt_srb_lock
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 4 Jan 2022 17:23:22 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dsmp+6aPx2HqhGU3fHFOvJ/4nWJw+MGDL4wD9ukdiTc=; b=NHEaFbuR8HYIrf/Ouy5YNDpTBlpVL0N+JMDlkfPOhO15Mls9Ky/Bn0xSs3j6fUhRmwGmu86upKIjTaJA2YckZA7aPfVdy7pNW3CLwpxpw/+cAAZjZnTVfgtQ2W+Xrn9QKZcqJsUtT20qPkCrJ9YQiYJThQtlz0Vo8laYekY4l9o1Ag41GgZU8ic7pCpG22x3WdhdDaAwZexjqP1Usfnje4UkdHyJf88t5YtBKz8Ln4cAzPNMq544OfFNd7Rbgg3p1JLazdVyv1c1CocLzzvcQPOLWu4ISAH3ntoufiRk98yOvXb+o45FWsdGVZnl4iHh7b4EDSly9/EOXYYuSKKk6A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z0mumByEHgVDLIMe8Yq4HlGdcT+N7O25OEEgZLarBjvaWXEbn/xjvLQy62q/Uvx7tQbTkcI5g5pZI8Y9xipTgJE4/Y5RipGY8qRJ2oNwvvDBwLnGM/Jju6PDF4S+/W4t+s3eMbhNR0VKSoriHlMQqWY7iUL9AN9tQIUUs8j6n5BXNW1chKj03iRUJWG/zAJsTzyj3ZEXkIN/G0a7uY3NkEpalPCRu0qXdaizf7OMYvBQFsi+VSdw2L0ENpQk4eS5BrWzuQg9VY3YyMxRWGGg2EAeXkHnl7qowBNt189WUhZSSFrUq4ttz82s175gLWWZH+SHOJmnN7MUPVqVoVnNzQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 04 Jan 2022 16:23:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04.01.2022 15:44, Andrew Cooper wrote:
> Since this logic was introduced, opt_tsx has become more complicated and
> shouldn't be compared to 0 directly. While there are no buggy logic paths,
> the correct expression is !(opt_tsx & 1) but the rtm_disabled boolean is
> easier and clearer to use.
>
> Fixes: 8fe24090d940 ("x86/cpuid: Rework HLE and RTM handling")
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
|
