[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 16/18] x86: introduce helper for recording degree of contiguity in page tables
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 4 Jan 2022 09:57:50 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s4PiulLQySHBEey5EYICd2Kk4uZhn81jQFy7AseADVU=; b=GzaTCdEFBCmbM0c2ciJeBI8tB9DtXA7vUDHbbBey8Aaq1hFBEh/YeCOH7ic1SXIoKlV8FhABGEpe5/RY/LhMHGDtrKH6t+lhN9PHBpfWnkGK9oglI4VYdtjWijzvKO9GWCnl4/Wj4jor4XfryLWsBl5Fz5hz+TRYtYWdygp9tvXh24u2RoHEEyVuaybIs0DZzhZdLMcCS7kYgrgkw5tTkDdIWbBq4Yt267ObSygps0wVPaX9orOxzJP7Ym2oe5MAxTMBtOhh9KB6oNk7O0oRttL2FhYlo7NpsFItlui8tQXIs1DqAueVLnmmUtONBXur6V/pky9W3YwgnMRC3558mQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cMDmDjOsqqEGCe1oy3paCei54BbmxUOmEdEPGjIWbziXsEGDRwS+cW/w9eV1INBtEV5eLaTOCERHclglVbdeY3koeLaf0nKHgHT7vLoCkNbaE2n4vLMh2FfSuHDFf+wtDC7XWaU+Pry+BorWCqyD/MowwqIzkuoFLowOhSCxGiDpTqqxEZ1chvb10F0MjJKis3pZJpTwl4pF01hpBMMStQ8i8ZP9kUBHavel/WFMfb/jRYng+2HYdpKhtHxO1Rmh+suvXK01T6vOH8reHw+zrmDaDpzobgNhpQ8//+ZpeFGTdOfzhwiKUrzyQjby2z8w4FLCioq/qVJyFKcAgltqDg==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 04 Jan 2022 08:58:33 +0000
- Ironport-data: A9a23:HxvrH6w7xyoC+tNdFW96t+fowSrEfRIJ4+MujC+fZmUNrF6WrkVSx jQfWmmCb6qLYWLxKdl1aIW0p0kHu8TRz4M2SAo6qiAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnvopW1TYhSEUOZugH9IQM8aZfHAhLeNYYH1500g7wrZl2tcAbeWRWGthh /uj+6UzB3f9s9JEGjp8B3Wr8U4HUFza4Vv0j3RmDRx5lAa2e0o9VfrzEZqZPXrgKrS4K8bhL wr1IBNVyUuCl/slIovNfr8W6STmSJaKVeSFoiI+t6RPHnGuD8H9u0o2HKN0VKtZt9mGt44s9 cRSqa63dTskBLLJgOEXFAhhEhgraMWq+JefSZS+mcmazkmAeHrw2fR+SkoxOOX0+M4uXzsIr 6ZBbmlQMFbT3Ipaw5riIgVort4kI8TxepsWp1lrzC3DDOZgSpfGK0nPzYEBhmtu3pkSdRrYT +4JNDAocQryWQRgJXgtFbZl28zxmFCqJlW0r3rK/PFqsgA/1jdZyLHwNPLFd9rMQt9a9m6Ho krW8mK/BQsVXPSdwzeY9nOnhsfUgDj2HokVEdWQ5vNsxVGe2GEXIBkXTkeg5+m0jFakXNBSI FBS/TAhxZXe72TyEIO7BUfh5ifZ4FhMALK8DtHW9inTl5fF/BqrAVQ4QwRebcQjvognfD0Tg wrhc8zSORRjt7icSHS4/7iSrC+vNSV9EVLudRPoXiNevYC9/dhbYgbnC486TfXr1oGd9STYn mjikcQou1kEYSfnPY2f9EuPvT+jr4OhouUdtlSOBTLNAu+UieeYi22UBbrzsacowGWxFADpU J04dy+2trpmMH11vHbRKNjh5Znwjxp/DBXSgER0A74q/Cm39niocOh4uW8ifR0yb5teJWGyO Cc/XD+9A7cJZxOXgVJfOdrtW6zGM4C9fTgaahwkRoUXOcUgHON21CpveVSRzwjQfLsEyskC1 WOgWZ/0Vx4yUP0/pBLvHrt1+eJ7l0gWmDKILbimnkvP7FZrTCPMIVvzGADVNb5RAWLtiFi9z uuzwOPWkUgCC7OnPXGMmWPRRHhTRUUG6VnNg5U/XsaIIxZ8GXFnDPnUwLg7fJdikbgTneDNl kxRkGcCoLYmrXGYewiMdF55b7bjAcR2oX4hZHR+Nle0wXkzJ42o6f5HJZcweLAm8s1lzOJ1E KZZK5nRXKwXR2SV4SkZYLn8sJdmKEahizWRMnf3ezM4ZZNhGVDEo4e2Ygv1+SASJSOrrs9i8 aa43wbWTMNbFQRvBcrbcty1yFa1sSRPke5+RRKQcNJSZF/t4M5hLCmo1q07JMQFKBPiwDqG1 lnJXUdE9LeV+4JsqYvHn6GJqYutAtBSJEsCEjmJ96uyOAnb4nGnnd1KXtGXcG2PT2jz4qijO 7lYlqmuLP0dkV9WmINgCLI3n7km7t7iqrIGnARpGHLHMwaiBr96eyTU2MBOsutGx6NDuBvwU UWKo4EINbKMMcLjMVgQOAt6MbjTiaBKwmHfvaYvPUH3xC5r577WA0xdMi6FhDFZMLYoYpgux v0suZJO5gGy4vbw3g1qUsyAG7ywE0E9
- Ironport-hdrordr: A9a23:QGPQzqxSXlufT/BONjMdKrPxtOskLtp133Aq2lEZdPULSKOlfp GV8MjziyWYtN9wYhAdcdDpAtjmfZr5z+8O3WB3B8beYOCGghrSEGgG1+XfKlLbak/DH4JmpM Jdmu1FeaHN5DtB/LfHCWuDYq8dKbC8mcjC74eurEuFDzsaE52Ihz0JdDpzeXcGIjWua6BJcK Z1saF81kWdkDksH4+GL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC X4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmRwXue iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqUneXJABYBT+ZRj4NQdRXUr2A6ustn7a 5N12WF87JKEBLphk3Glpb1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI BVfY7hDc5tABOnhk3izypSKITGZAVwIv7GeDlPhiWt6UkWoJgjpHFogfD2nR87heUAotd/lq D5259T5cJzp/ktHNZA7dc6MLuK41P2MGDx2UKpUB3a/fI8SjrwQ6Ce2sRB2AjtQu1O8KcP
- Ironport-sdr: HKSW5DSVJVjKlU7FZdYR+RB007vYsBn2YtsvyjOgkl9wRymFKzjHIo62oYgfQ1qyppzwllcvDR MgaLdNV1ZSe+WT8ZhO3TX2+a1AxUIy5oLwRA2oYvSS/AovyqSiH4q5quNeWrGjcHQOZb73jU7d XcE0CzFPjqxs58kkLBE/ZoR/wV3BBxE0Jiu/3O2OtM59aojRg9DjvzDFVSZVyHCmpg8Njs7On1 pkhxNR8+0Ow6cJXqA5kr86vtBw7ub4PfOM+taZxYa4p4pXBS1HZKICY/dCJROsKPYYjL3miGcB 9Ibg5MGy/5ZW/eJL8ROjnhLb
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Dec 21, 2021 at 09:09:45AM +0100, Jan Beulich wrote:
> On 20.12.2021 16:25, Roger Pau Monné wrote:
> > I think it might be interesting to add some kind of unit testing to
> > this code in tools/tests. It's a standalone piece of code that could
> > be easily tested for correct functionality. Not that you should do it
> > here, in fact it might be interesting for me to do so in order to
> > better understand the code.
>
> Actually I developed this by first having a user space app where I could
> control insertions / removals from the command line. Only once I had it
> working that way was when I converted the helper function to what's now
> in this header. But that user space app wouldn't directly lend itself to
> become an element under tools/tests/, I'm afraid.
Also, I'm curious, did you develop the algorithm yourself, or is there
some prior literature about it? I wonder how other OSes deal with this
problem if they support coalescing contiguous pages.
Thanks, Roger.
|