Re: [PATCH v2 04/10] mini-os: respect memory map when ballooning up

[Juergen Gross <jgross@xxxxxxxx>]

On 21.12.21 00:22, Samuel Thibault wrote:
> Juergen Gross, le lun. 20 déc. 2021 17:07:10 +0100, a ecrit:
> > +unsigned long e820_get_max_contig_pages(unsigned long pfn, unsigned long pages)
> > +{
> > +    int i;
> > +    unsigned long end;
> > +
> > +    for ( i = 0; i < e820_entries && e820_map[i].addr < (pfn << PAGE_SHIFT);
> Shouldn't that be addr+size? Otherwise if pfn is in the middle of an
> e820 entry, we will miss picking up that.
No, we want to check all map entries starting below or at the given pfn.
The test should be "e820_map[i].addr <= (pfn << PAGE_SHIFT)", of course.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature