[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v8 14/47] build: rename __LINKER__ to LINKER_SCRIPT
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 15 Dec 2021 08:49:54 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6hjPK7PHXBANagm/R9dQprIb3qUp/MtlmAJs19zyROc=; b=UjhSIgq2TiWu9ypt07AkdVx4X1Zol8b+k4PEkyPRc12zntC8wGZwwl0ragEV5NKMbUE+iLT5+/wlrbmqEofGJX2+RCWW+kfP2Ap8UwTlo4BBDeLHUIyV2rhNZn4XwXfMJZWz3K1+tfj0Eum6+rlLkuWB0HodzbQrT9sgsZy239yjQrK+tMkgML71vvurOdKNXEB1pF5yGvD83WGpTmgT4dAIj+AXW2wRk1uqIima4APTxcVte2q5ttjCU8gco5Qm8HImElnEKWltZxV2DUzgtrLbww4OoAO9oXNQWRFP6ZyGn6PjJEcndRj6XUuwrtQUQZKm+RSVx09FG/GEjfpRSA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DIV+psMwmzz/RMeG4PvXL8z8zzdIBp7Qzy4JEZBiog6sHp/EswkppcmAMCU5qKZfDr5aHd+n3pm6bvrVGmO3sf1WwoOKo7DUA8vS/zWwuangscXEAYZYNBJKdoLxTCvlHTsoXwJbzyHDN5dsNMkNHCnYjV+PBUUlSDMbB7jB2vHQzMHRVU+ZKqfa7snf+mad9OFOgMU8xUYqsWETuQY7Xk96Uu5E9KiDBMvDFx+Phmk77C1Ltqx3KFbvK7QqT0r5Snk+ngJy+IK6zBKg02fojNwlXO/myoQDxdwSndv2iSX7nrZN0RsspM/Wf6X+iv05SkoKv9qQ/I+Sabz2Syk6mw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Wed, 15 Dec 2021 07:50:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14.12.2021 18:05, Julien Grall wrote:
> On 25/11/2021 13:39, Anthony PERARD wrote:
>> For two reasons: this macro is used to generate a "linker script" and
>> is not by the linker, and name starting with an underscore '_' are
>> supposed to be reserved, so better avoid them when not needed.
>
> If that's the case, then shouldn't we also rename __ASSEMBLY__?
I'd rather not - unlike __LINKER__ (afaict at least) __ASSEMBLY__
is a commonly used identifier (which we've actually inherited from
Linux).
Jan
|
