[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] xen-blkfront: Use the bitmap API when applicable
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 14 Dec 2021 12:08:26 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=73NJWetcVUrSo6Bba6C96xaPBU2yixLWFWq42EYFVtE=; b=mZwzQ80avLBZvllUUK8cAIORSfk19ahN9QlrTrryelBUbfkT3fz7GBHjNiQtSWutdYyX1YPffKrLEWPxc2cd1kWi+AUd3ukM+viNsHzoi9jooDB/zuI4la8nD7cquxBy7UXN6rJotr7iISIgkl0UXmkHG07/pC1EGDi9X5cR7as5a1l09PC1MOXk0uwmhxDZ+mv3jgWA5Ik3i2njmDiqJ0hlKrwq9W/skXWUMeCldT6Otr3agYwCDVgcYysITX1BJHfjd4CDiKUVWkIiJwbfhQ+nV70wBuoofkMq+9ZeaTj8FnYpyDp944QTZo6sw9ZWkB3YA56IFdpmWB7VN+oiTA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kuYPJW8sdJpKXA0L1MuvjnJNJ9cdc0i3elUUcWC920hUpT4DXgE06ZOSCT5QJoe+hbBKzRz3QriGuAn815QUk+az/7nk6Q26TYvgY/5623Z66RtrrLZdZ+tRDd+Mfke+lPZNx/kD2xZTM/vh6Z42qoMJ9t5FiNqbUMtquw+MnYzuzjDgBhxcWNZ/Qj1ZznfFD99Tfu/ojeIk4ykj5jUHospylDFRX0dSzE3g0cmWdWBV7p3LeUJWr3qNLvjqEzLmAaqkQ+V7rALEWgrzst+5cUqIlonJ2VdKvQjnhgAVmA27ifH7U1SZk9MW7QfEJB8QfriI/uDYz8Sl62Dy4XO02Q==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>, <boris.ostrovsky@xxxxxxxxxx>, <jgross@xxxxxxxx>, <sstabellini@xxxxxxxxxx>, <axboe@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <linux-block@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <kernel-janitors@xxxxxxxxxxxxxxx>
- Delivery-date: Tue, 14 Dec 2021 11:08:56 +0000
- Ironport-data: A9a23:Azrtmq7Cgv7AyYhnYhMirQxRtDHBchMFZxGqfqrLsTDasY5as4F+v jEZCDuHO/iJazamL4p3b9/koRhUucDWydVkQFdk/ikyHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FV8MpBsJ00o5wrdj29Iw27BVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zx tlUjs2SeFYTJYLIhvQnDUhXIzFPBPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgm1o3ZESQ6u2i 8wxRR1ybU7yfBx2ZFoLDsIGh7uSmyjBbGgNwL6SjfVuuDWCpOBr65DpMdzIapmAQcJenW6Gq W/cuWf0GBcXMJqY0zXt2mKhgKrDkD32XKoWFaak7bh6jVuL3GsRBRYKE1yhrpGRiUOkXd9bb k4d/CsyqrIp3FKkQ8O7XBCipnOA+BkGVLJ4F+w89RHIyafO5QudLnYLQyQHa9E8ssIyAzsw2 TehlsPjAjFHs7CPT3+ZsLuXxRu4PjIUNikFfjMeShUe4MjLp5s6hRbCCN1kFcadhd3vGCrsx CiKoW48jrQXicMX/7qy+1nLhDXqqIKhZhUu+gzdU2ah7wV4TI2ofYql7R7c9/koBISWVF6ap 1AfhtOTqusJCPmweDelGbtXWuvzvrDcbWOa0QUH84QdGyqF9XK6RtFy0WBEP2htLNY+J27mU F/igFYEjHNMB0eCYahyaoO3Ls0ly6n8CNjoPszpgspyjotZL1Heonw3DaKE9yW0yRV3z/ljU XuOWZ/0VS5yNEhx8Nahqw7xO5cPzzt2+27cTIuTI/+PgevHPy79pVvo3TKzggEFAEGs/FW9H zV3bZLiJ/BjvAvWOHa/HWk7dw9iEJTDLcqqw/G7j8baSuacJEkvCuXK3ZQqcJF/kqJem4/gp y/mCxMCkQKi2yKWeW1mj0yPjpu1Av6TSlphYkQR0auAgSB/Me5DEo9BH3fIQVXX3LM6lqMlJ xX0U86BHu5OWlz6F8c1NvHAQHhZXE3z32qmZnP9CBBmJsIIb1GYorfMI1q0nAFTX3XfiCfLi +D5vu8tacFYHFoK4Qe/QK/H8m5dSlBBwr8vBBWRfYEIEKgumaAzQxHMYjYMC5hkAT3IxyeA1 hbQBhEdpOLXpJQy/sWPjqeBx7pF2cMndqaDN2WEv7uwKwfA+W+vnd1JXOqSJGiPX2Lo4qSyI +5SyqikYvEAmV9Ltat6Eqpqkv1it4e++ecCw1Q2BmjPYnSqFqhkfiuM0/5Qu/Af3bReowa3B B6Co4EIJbWTNcr5O1cNPw55PP+b3PQZl2CKv/Q4KUn3/gFt+7+DXRkANhWAknUFfrB0LJkk0 aEqv8tPs16zjR8jM9CniCFI9jvTcixcAvt/7pxDWd3lkAsmzF1GcKfwMC6u7cHdcchIP2krP iSQ2PjIiYNDyxeQaHE0D3XMg7ZQ3MxcpBBQwVYeDF2Vgd6Z1OQv1Rhc/DlrHARYyhJLj7B6N mRxbhAnIKyP+3FjhdRZXnDqEAZEXUXL9kv0wloPtWvYU0j3CTCdcDxjYb6ArBID7mZRXjlH5 7XJmm/qXAHjcNz1wiZvC1VurObuTIAp+wDP8Cx98x9pw3XujeLZv5KT
- Ironport-hdrordr: A9a23:qxryUqAY2aqKuKTlHeg2sceALOsnbusQ8zAXPh9KJyC9I/b2qy nxppgmPH/P6Ar4WBkb6La90Y27MA7hHPlOkPUs1NaZLXPbUQ6TTb2KgrGSpgEIdxeOktK1kJ 0QDJSWa+eAfWSS7/yKmDVQeuxIqLLsndHK9IXjJjVWPHpXgslbnnZE422gYzRLrWd9dP0E/M 323Ls4m9PsQwVcUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZvzU H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDj1H8a1P 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXoyEfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16 pNwiawq4dXJQmoplW92/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp ghMCjl3ocUTbqmVQGagoE2q+bcG0jbXy32DXTqg/blkwS/xxtCvg8lLM92pAZ3yHtycegC2w 3+CNUbqFh5dL5gUUtMPpZzfSKJMB25ffvtChPbHb21LtBNB5ryw6SHlIndotvaPqA18A==
- Ironport-sdr: B8Z1VmTAJwOsifiTBGGNYVhTDSDM+MiSB/GML7aO9RqIUVPhBdPrfQ9qWqxmy2ADGVbP2Xb5Bw whNArWDYilhGr7pwMwRXsi1V6+Tgl8+uLQ8pb8IQ3928wZ1K2zhXpiPffb40UlR5CZ/j/G/i3p OeyVQRiEaabDaBxjLNGnJSdTR9OklxVIHP3VRsRYqJM63el5/P9bwLePTYWy/KSpJ2krLdwtt6 T6Xpbbbd5em52TTHkBrmPTAS6mUP6dSpSvrnEFDpCxMPDABINNysZB4qmVv8XSTjYUyDl5B6Yn bsZ5mtz5NjWiUB/SMicZpHnk
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Dec 14, 2021 at 11:59:39AM +0100, Roger Pau Monné wrote:
> On Thu, Dec 02, 2021 at 09:16:04PM +0100, Christophe JAILLET wrote:
> > Use 'bitmap_zalloc()' to simplify code, improve the semantic and avoid some
> > open-coded arithmetic in allocator arguments.
> >
> > Also change the corresponding 'kfree()' into 'bitmap_free()' to keep
> > consistency.
> >
> > Use 'bitmap_copy()' to avoid an explicit 'memcpy()'
> >
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
>
> Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Oh, I see there's been further discussion on this to avoid relying
implicitly on the size of the bitmap being rounded to the size of an
unsigned long. I think a new version is expected then?
Thanks, Roger.
|
