Re: [XEN PATCH 18/57] tools: Use config.h from autoconf instead of "buildmakevars2header"

[Juergen Gross <jgross@xxxxxxxx>]

On 07.12.21 11:49, Anthony PERARD wrote:
> On Tue, Dec 07, 2021 at 11:08:55AM +0100, Juergen Gross wrote:
> > On 06.12.21 18:02, Anthony PERARD wrote:
> > > This avoid the need to generate the _paths.h header when the
> > > information is from autoconf anyway.
> > >
> > > They are no more users of the "buildmakevars2header" macro, so it can
> > > be removed from "Config.mk".
> > >
> > > Also removed the extra "-f" flag where "$(RM)" is used (xl/Makefile).
> > >
> > > Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> > The changes for configure should be done in the respective configure.ac
> > files and then configure can be generated via a call of "autoconf".
> This is what this patch does, via changes in "m4/paths.m4" ;-).
> All the respective "configure.ac" have "m4_include([m4/paths.m4])", so
> nearly any modification to "paths.m4" will change the generated
> "configure" script.
Oh, I just looked at the modified files and didn't see any *.ac ones.

I was already wondering how you could miss that, especially as you did
it correctly in the next patch. :-)

You can then add my:

Reviewed-by: Juergen Gross <jgross@xxxxxxxx>


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature