Re: [PATCH] xen/arm: Add Kconfig parameter for memory banks number

[Andrew Cooper <amc96@xxxxxxxx>]

On 06/12/2021 15:37, Luca Fancellu wrote:
> diff --git a/xen/include/asm-arm/setup.h b/xen/include/asm-arm/setup.h
> index 95da0b7ab9cd..785a8fe81450 100644
> --- a/xen/include/asm-arm/setup.h
> +++ b/xen/include/asm-arm/setup.h
> @@ -6,7 +6,7 @@
>  #define MIN_FDT_ALIGN 8
>  #define MAX_FDT_SIZE SZ_2M
>  
> -#define NR_MEM_BANKS 128
> +#define NR_MEM_BANKS CONFIG_MEM_BANKS

$ git grep -wc NR_MEM_BANKS
arch/arm/bootfdt.c:1
arch/arm/domain_build.c:5
arch/arm/efi/efi-boot.h:3
include/asm-arm/setup.h:2

For this few instances, it is probably better to use CONFIG_MEM_BANKS
everywhere, rather than add the level of indirection.

~Andrew