[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] EFI: move efi-boot.h inclusion point
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Luca Fancellu <luca.fancellu@xxxxxxx>
- Date: Mon, 6 Dec 2021 08:39:35 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DXPbVL2EdEFUiGXcxX5ln7kXU648RW6dIlZm86JJVgo=; b=PkwoAmfG1Q/bkeYoTS8L9kCB+Lv4ChUsNdHmzASbW8OisvsBhSDChNQg7hR7PnjnIc2BDFCn+L78mpM0wLCte3aUpo7f6to59vkuR0GCK0ytG7oXB62jL0XrajWcIxZLiP6CfWXCoRFgfdJm2Eev/HlkEDnGpM9TQCU0A7QA0ZHmhEFfh3/9ss1/qRf8BSq2UsAWcXaoDtC/pCH2j9uq+HnydKLD1S5qEIFNio6plUQOQZLeJwCWh48+Chcj8WZLYFLmqgRoS0liyoM2OBYQvQhwjAVttBuPhtb73rW5XhnpGIRMtf4k0fgfjtiSO9cFJbSvGQx3VHmu336RcpBXQg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WRlEC2FT+0nPVtObVgZbZTJzYB2Mf356lvyBRC+CyZ08WdJRt1eMTwss7cONv3sBsJ0wikyZTyaMOqO1UKTGd9rjbZI83tFNRHIRNaN4qd9GQGuXeBtHKCDRyBXcyEXwadMtmTV0DmjK1JtZejAow0CiXj65Ypu6abg558T2Q3b9Rc4oN9IS5AN/K3UHrCah6jJ6yjF2R7g4JGIqg1Ug18PN4BShtYf6k6b8qXM73X0G1YMCDDDKfY6hBw0kpIoOjuD5mdSoZ9yrpoQp2SmfhATndLsQUaJNQN2sO+A8cOo/uu/voaQZuzDVcJmwuwZExZKqzFdYwM8LCDjbfwfsxg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Mon, 06 Dec 2021 08:40:14 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
> On 6 Dec 2021, at 07:27, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 03.12.2021 17:10, Luca Fancellu wrote:
>>> On 3 Dec 2021, at 10:56, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>>
>>> When it was introduced, it was imo placed way too high up, making it
>>> necessary to forward-declare way too many static functions. Move it down
>>> together with
>>> - the efi_check_dt_boot() stub, which afaict was deliberately placed
>>> immediately ahead of the #include,
>>> - blexit(), because of its use of the efi_arch_blexit() hook.
>>> Move up get_value() and set_color() to before the inclusion so their
>>> forward declarations can also be zapped.
>>>
>>
>> With the “const” attribute now some function in this serie are above the
>> char line
>> limit, however everything looks fine.
>
> I wonder which part of this patch you're referring to. I don't recall any
> addition of const here - I think I'm strictly only moving code around some
> code and delete some declarations. I've further checked the code being
> moved, and I couldn't spot any line going beyond 80 chars.
Yes sorry, it was a comment for the second patch, where you constify a
function parameter
>
>> Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
>
> Thanks.
>
> Jan
|
