[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v2] bitops: Fix incorrect value in comment
Hi, On 30/11/2021 18:12, Ayan Kumar Halder wrote: GENMASK(30, 21) should be 0x7fe00000. Fixed this in the comment in bitops.h. I am afraid this commit message is incomplete. You say you just corrected the bitmask returned but... Signed-off-by: Ayan Kumar Halder <ayankuma@xxxxxxxxxx> --- Changelog :- v2 :- 1. Replaced the word "vector" with "value" in comment. 2. Changed 0x07fe00000 to 0x7fe00000. 3. Updated the commit message to make it meaningful. (All suggested by Jan Beulich) xen/include/xen/bitops.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/xen/bitops.h b/xen/include/xen/bitops.h index a64595f68e..dad4b5aa1e 100644 --- a/xen/include/xen/bitops.h +++ b/xen/include/xen/bitops.h @@ -5,7 +5,7 @@ /* * Create a contiguous bitmask starting at bit position @l and ending at * position @h. For example - * GENMASK(30, 21) gives us the 32bit vector 0x01fe00000. + * GENMASK(30, 21) gives us the 32bit value 0x7fe00000. ... there are two extra changes here: 1) The bitmask is now described with 8-characters (rather than 9) 2) 'vector' is replaced with 'value'The former makes sense to me, but it is not clear to me why the latter should be changed. Cheers, -- Julien Grall
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |