[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fixed an incorrect value
- To: Jan Beulich <jbeulich@xxxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxxxxx>
- From: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxxxxx>
- Date: Tue, 30 Nov 2021 09:37:36 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=suse.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SGAqY3rQKfk9bdVR7tekPQeLGr47yvIFoW+d0eFlWrI=; b=PVzxdWmaW+Fj5Ggm5sv8LFKoBNDkPqQnOo/2EdJT4QBKT2Nafo6WHwz+u/6Bm6CfgcStELVkmraIXiSUV3JmRHwor4JaM9n120YVaaNk74j+/J4xMwkZHfjXX9F84y58FmdZtlYU8T/l1g5jGrLIgFbqeNkWjUea4dzDZHx/gk8aobQszbY53z4JZToZkXzqogD35jXWFJomoLed6z6sggLQQ/KVuMma/8fBAMRdtDxAuTbDTcs5RLG/VHk+wO0O+GZpTYYTdt2/XxwPQkoCs8YbSqhc2cVcMkvYjRNrrKmOE26TiE6uvcp/W63fOwDgB1IQ2fu0ief/X34sYyoGog==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VebqSD2otrL0s47bIKk7LlJ+Ndlcq7vmwk86j6wWbgK+9RQVnddl1eGN403ZPIq+EHA2p4q/H4ZUugeDEYTUhQlg8flusRFp/0sZB5l/+hqr95KRH4LGck5n0AqmZduuxqrXoSXPROBuH0YJqEH6yD7Emnflp4s1DL0q8P1wHoOQ68ys8zO/vrbnxi0Ni3kJ+z1aW+3GwxIR7WARyp14bH4aVTL6mGsJ6S6WuLKwnVRh/KKFnICNH+6ZnSkT+ic7B0xelp0wFTKjlcsa3LRlqhORCpWRlpDoVYBuNHjv2RQZIJRfjNF9AY1+3z0BM2Kzoio0qT7kpK0gbJJZzPPc9A==
- Cc: <sstabellini@xxxxxxxxxx>, <stefanos@xxxxxxxxxx>, <julien@xxxxxxx>, <Volodymyr_Babchuk@xxxxxxxx>, <bertrand.marquis@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 30 Nov 2021 09:38:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Jan,
Thanks for the review. Just one question.
On 30/11/2021 07:18, Jan Beulich wrote:
On 29.11.2021 20:44, Ayan Kumar Halder wrote:
GENMASK(30, 21) should be 0x07fe00000
Please can this have a meaningful title? E.g. "bitops: fix incorrect
value in comment"?
--- a/xen/include/xen/bitops.h
+++ b/xen/include/xen/bitops.h
@@ -5,7 +5,7 @@
/*
* Create a contiguous bitmask starting at bit position @l and ending at
* position @h. For example
- * GENMASK(30, 21) gives us the 32bit vector 0x01fe00000.
+ * GENMASK(30, 21) gives us the 32bit vector 0x07fe00000.
Once at it I think you also want to
- replace the word "vector",
Should I replace "vector" with "value" ?
- Ayan
- drop the odd leading 0: The number would better be 8 digits or
16 digits, but not 9.
Jan
|
