[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 06/11] vpci/header: handle p2m range sets per BAR
- To: Jan Beulich <jbeulich@xxxxxxxx>, Oleksandr Andrushchenko <andr2000@xxxxxxxxx>
- From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- Date: Fri, 19 Nov 2021 13:41:12 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mdjUaUuvmkK2au7R7pSabC6xgXPInAR5bksrHymMn6g=; b=Qhr8Ihg7EIeyEgJ7KMJY8ltvof6Y0gB0v6PqXU2aUj6XXvmZTh8QKUt0sfmDXqpWyXC/mx5dq1l9P+nvb5D/1Z2KRI3gne1I0pz9JX4k4DhktFErGemJfuJhRj5uO1V4UdZa4PsHENanAM1LEoJUOr+HflTZoZiiPM71DQHxOiTAHQxTXnPiBmYrbrz14MtIWQfE2WCWnnvxuiFn1FPRP5jqEkET+/8umNaiwgqKzxS11howA69BAt7cNeczJWy4On6pbi7LdF7t7WFtEaApA1T5MvftgNSh4IhX4G19al4ySvVBA1gceNCf6lOdl051g1OTeQwQ8zFWA9TIzDW6MQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OQJoyFCrE0xHuLF1S7gMmRN8WakALixnsUlMDjLXlr+TzjDxKt0NUgip7FvyNlg+qwrzoYleHJqbsbK0zR1UuJXPOXFktOhWUdq5dnc1xmKqyEqq3NRhpy/3TDAP74EnsvdtzA+m28W9WOyGw9kuKCBJwoVpSaeApHm4nWan1on9VTnBu5HedOKlnjbN11dy3OZmuckbdbRnSMW0oFyS+6ndYoQS/2/5KEg6DLIBk26chx9J/LdMyJ8vBrEz1kLW6pJGWQa6txbg+m8zi7gUHilyCRDH20ESWLRtGEaHjjxRDfF4a5IuqS46ZyobyBG2LReBISiGZo0FcAVGjDwUHA==
- Cc: "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "george.dunlap@xxxxxxxxxx" <george.dunlap@xxxxxxxxxx>, "paul@xxxxxxx" <paul@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 19 Nov 2021 13:41:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHX0hJLwt+wJ2t1lka5jlbMIq7ZAqwK60SAgAAG0YA=
- Thread-topic: [PATCH v4 06/11] vpci/header: handle p2m range sets per BAR
On 19.11.21 15:16, Jan Beulich wrote:
> On 05.11.2021 07:56, Oleksandr Andrushchenko wrote:
>> @@ -95,10 +102,25 @@ int vpci_add_handlers(struct pci_dev *pdev)
>> INIT_LIST_HEAD(&pdev->vpci->handlers);
>> spin_lock_init(&pdev->vpci->lock);
>>
>> + header = &pdev->vpci->header;
>> + for ( i = 0; i < ARRAY_SIZE(header->bars); i++ )
>> + {
>> + struct vpci_bar *bar = &header->bars[i];
>> +
>> + bar->mem = rangeset_new(NULL, NULL, 0);
> I don't recall why an anonymous range set was chosen back at the time
> when vPCI was first implemented, but I think this needs to be changed
> now that DomU-s get supported. Whether you do so right here or in a
> prereq patch is secondary to me. It may be desirable to exclude them
> from rangeset_domain_printk() (which would likely require a new
> RANGESETF_* flag), but I think such resources should be associated
> with their domains.
What would be the proper name for such a range set then?
"vpci_bar"?
> Jan
>
Thank you,
Oleksandr
|