[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[4.16?] Re: [PATCH v2] public/gnttab: relax v2 recommendation
- To: Ian Jackson <iwj@xxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 15 Nov 2021 10:57:46 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bdR5JVDXfYFw1Jkxd4yujs7nOjGCUFmjmKVbMM5vNn0=; b=NbUFlbpDnUsAfHspD61O6zp3pQpMifFnDGLJxz+yWKMsjZKV8UQdYEy+RnaZPxlKCP9ZVfbQ0iSHMy0Xu6a24sndvAhFfu2/k2fJa1nuNl7fCLouu6NQT+UcYHzp/uP/BkBYruL5jd/I28ZEaqLLioLbhYXu8bn3tVMG1G1WE53GlCsdxY0NbZzwLCojmemplMJicxHUlkEFZyLF6DP33eNUy5sy+UAQBDbVb6yIIFI0DaRJTUu6/aXZS9/3OBY73INKUyh/s+zR2ksY9jmwUpfp+67zOnhodw8wdGQoSqfVXSvXpLuPQwN+x+mkZd3TxXIP0YO2XB2tMqw48MC0xA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PSb/PdbVmMq4uTH8scl9ip9S2q1kl9QTj4NcU1z7Udu2dhqdldmu0YPTDaoPKXS8Hrf1lTcqnBu7FoDq5q98ObQdYW44X65kJKA/4qThWvXnkOk7QNtw0k//N+oMVV1pnH/CZJ9I8/TqVfGRCVfi2XjBE+uYYPHiDAZvxdgVZCYlrYibE3CTug39vM7lX74NipqNU6SwAGdXWJYQovO0MVc/BEG23WAhDQibGUyovn3cfEcJbp4Lso2xjE17HVVTfAvJ67VW43kdkj0cz0+PuYgdMhwQfgx/5RtaC8rr9Z60SSuLYTct4i9EnWE3fI4HGfyJE+VIgOmPIrn/kUKZtQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Luca Fancellu <luca.fancellu@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 15 Nov 2021 09:57:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 15.11.2021 10:55, Jan Beulich wrote:
> With there being a way to disable v2 support, telling new guests to use
> v2 exclusively is not a good suggestion.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> ---
> v2: s/be able to fall back/default/.
>
> --- a/xen/include/public/grant_table.h
> +++ b/xen/include/public/grant_table.h
> @@ -121,8 +121,9 @@ typedef uint32_t grant_ref_t;
> */
>
> /*
> - * Version 1 of the grant table entry structure is maintained purely
> - * for backwards compatibility. New guests should use version 2.
> + * Version 1 of the grant table entry structure is maintained largely for
> + * backwards compatibility. New guests are recommended to support using
> + * version 2 to overcome version 1 limitations, but to default to version 1.
> */
> #if __XEN_INTERFACE_VERSION__ < 0x0003020a
> #define grant_entry_v1 grant_entry
This being a comment only change (and hence close to zero risk) I wonder
whether this wouldn't still be appropriate for 4.16. I'm sorry for not
having remembered earlier to submit v2 of this.
Jan
|
