Re: [PATCH-4.16 v2] xen/arm: fix SBDF calculation for vPCI MMIO handlers

[Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>]

Hi, Julien!

On 03.11.21 20:17, Julien Grall wrote:
> Hi Oleksandr,
>
> On 03/11/2021 12:08, Oleksandr Andrushchenko wrote:
>>
>>
>> On 03.11.21 00:47, Stefano Stabellini wrote:
>>> On Tue, 2 Nov 2021, Oleksandr Andrushchenko wrote:
>>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>>>>
>>>> While in vPCI MMIO trap handlers for the guest PCI host bridge it is not
>>>> enough for SBDF translation to simply call VPCI_ECAM_BDF(info->gpa) as
>>>> the base address may not be aligned in the way that the translation
>>>> always work. If not adjusted with respect to the base address it may not be
>>>> able to properly convert SBDF.
>>>> Fix this by adjusting the gpa with respect to the host bridge base address
>>>> in a way as it is done for x86.
>>>>
>>>> Please note, that this change is not strictly required given the current
>>>> value of GUEST_VPCI_ECAM_BASE which has bits 0 to 27 clear, but could cause
>>>> issues if such value is changed, or when handlers for dom0 ECAM
>>>> regions are added as those will be mapped over existing hardware
>>>> regions that could use non-aligned base addresses.
>>>>
>>>> Fixes: d59168dc05a5 ("xen/arm: Enable the existing x86 virtual PCI support 
>>>> for ARM")
>>>>
>>>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>>> Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>>>
>>> Also, Ian already gave his release-ack.
>> Thank you,
>> Do I need to resend the patch with Acks? Or hopefully those can be applied
>> on commit?
>
> I have committed with the two tags applied.
Thank you
>
> Next time, please remember to carry Release-acked-by tag.
The Release-acked-by tag was sent by Ian *after* I've sent v2 of the patch
(this one) and it was in v1 mail thread....
>
> Cheers,
>