Re: [PATCH] PCI/MSI: Move non-mask check back into low level accessors

[Thomas Gleixner <tglx@xxxxxxxxxxxxx>]

Josef!

On Wed, Oct 27 2021 at 17:29, Josef Johansson wrote:
> On 10/27/21 14:01, Josef Johansson wrote:
>> diff --git a/kernel/irq/msi.c b/kernel/irq/msi.c
>> index 6a5ecee6e567..28d509452958 100644
>> --- a/kernel/irq/msi.c
>> +++ b/kernel/irq/msi.c
>> @@ -529,10 +529,10 @@ static bool msi_check_reservation_mode(struct 
>> irq_domain *domain,
>>  
>>      /*
>>       * Checking the first MSI descriptor is sufficient. MSIX supports
>> -     * masking and MSI does so when the maskbit is set.
>> +     * masking and MSI does so when the can_mask is set.
>>       */
>>      desc = first_msi_entry(dev);
>> -    return desc->msi_attrib.is_msix || desc->msi_attrib.maskbit;
>> +    return desc->msi_attrib.is_msix || desc->msi_attrib.can_mask;
>>  }
>>  
>>  int __msi_domain_alloc_irqs(struct irq_domain *domain, struct device *dev,
>>
> Hi Thomas,
>
> With the above added the kernel boots fine and I can even suspend it twice.
> Which is with my laptop, a good sign.
>
> You can add Tested-By: josef@xxxxxxxxxxx.

Thank you for fixing my quick hack in vacation mode. I'll send out a v2
in a minute.

Thanks,

        tglx