|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [OSSTEST PATCH 0/2] ts-xen-build: explicitly enable/disable configure features
Juergen Gross writes ("Re: [OSSTEST PATCH 0/2] ts-xen-build: explicitly
enable/disable configure features"):
> Far from being a Perl expert I agree this is a sensible approach and it
> should do the right thing.
>
> It will still depend on no unsupported option being mentioned in any
> comment, e.g. "# option --enable-foo is no longer supported" will result
> in a wrong positive when testing for feature "foo". In the end this will
> break the build, so it should be easy to detect in case this happens
> some time in the future.
>
> As there is no way to print out all supported options, this could only
> be solved by adding "--disable-option-checking", which has other
> disadvantages.
>
> You can add my:
>
> Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
Thank you for your detailed review and analysis.
I have pushed this to osstest pretest.
Ian.
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |