[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 01/11] vpci: Make vpci registers removal a dedicated function
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- Date: Wed, 27 Oct 2021 09:41:14 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/Zo3f8esKNcRTrfaKmhM4Ab8eifI1HDYItbapSkXCU8=; b=THh1Scnn4AqDGD0lGd2gT3ov96FhebP3d1NPEY+LhCAg+B7wjv8TFDiZFP97uUJpoG+D25tVjszWMt/KWwpzSwgT2TQ8l7iMh96PUmI8XRCUVIZJhnqkjaGerX9Zd6R3VXHC4b4uquie/fn0rFb3qiSvsPpnynMeLdHziCIYKwGKv/lvpci62h/y4BWhrjdRJdswfEHRcDfT8giiRlGUDzUVffrd/N1wWUyixpxRz29KbaGJrU/aSyF2RBcNsVe+CzUjwTb1tm1J/sca4Zwcmq4OyfLUCljD8KmQ4Cs0PH3pG9VudERYES6d1ooiSBMNkVizvxYXD53XioStnTCafw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=abl9azDnHaUtYamNfkqHcPk7m8Tr0uvt3st2JbwRpYo2FBGoH2w3FSfY6JHCyQ4//ipO2rekN+J5vF9KejqSb7CeYhGRWxvTggmkkEchknXkk+qoFpe42N4qtMm5wDF1ODeO/edOuf0O+BQ6LdRWftCVG3h8m7XZp+73gaT78Dh+NH47dOjjE6hJxbqZXiKR/4fbb2h3lgF2rjMWp+d1PQtz5u5fvl62zubclIKkcOzoHqAwAxoEJNSyuihWyCmDDYTNdbhDZv4Em19eO97RnwkvlJSeD63DboRAL3tactlcWJII0xSz9U8RUHMNKd0QlLnTVaKrdh+oMedBiFTsvA==
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- Delivery-date: Wed, 27 Oct 2021 09:42:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHXtdAgeXiPCGUCJ0Oi6HCqPD8Y4KvQ2oUAgBXfUACAAAN/AIAABJuA
- Thread-topic: [PATCH v3 01/11] vpci: Make vpci registers removal a dedicated function
On 27.10.21 12:24, Roger Pau Monné wrote:
> On Wed, Oct 27, 2021 at 09:12:14AM +0000, Oleksandr Andrushchenko wrote:
>> Hi, Roger!
>>
>> On 13.10.21 14:11, Roger Pau Monné wrote:
>>> On Thu, Sep 30, 2021 at 10:52:13AM +0300, Oleksandr Andrushchenko wrote:
>>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>>>>
>>>> This is in preparation for dynamic assignment of the vpci register
>>>> handlers depending on the domain: hwdom or guest.
>>>>
>>>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>>>> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
>>>> ---
>>>> Since v1:
>>>> - constify struct pci_dev where possible
>>>> ---
>>>> xen/drivers/vpci/vpci.c | 7 ++++++-
>>>> xen/include/xen/vpci.h | 2 ++
>>>> 2 files changed, 8 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
>>>> index cbd1bac7fc33..1666402d55b8 100644
>>>> --- a/xen/drivers/vpci/vpci.c
>>>> +++ b/xen/drivers/vpci/vpci.c
>>>> @@ -35,7 +35,7 @@ extern vpci_register_init_t *const __start_vpci_array[];
>>>> extern vpci_register_init_t *const __end_vpci_array[];
>>>> #define NUM_VPCI_INIT (__end_vpci_array - __start_vpci_array)
>>>>
>>>> -void vpci_remove_device(struct pci_dev *pdev)
>>>> +void vpci_remove_device_registers(const struct pci_dev *pdev)
>>> Making this const is kind of misleading, as you end up modifying
>>> contents of the pdev, is just that vpci data is stored as a pointer
>>> inside the struct so you avoid the effects of the constification.
>> Ok, I will remove const
> Jan prefers the const, so please leave it.
Ooook )
>
> Thanks, Roger.
>
|
