[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 1/2] arm/efi: Use dom0less configuration when using EFI boot
- To: Luca Fancellu <luca.fancellu@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Julien Grall <julien@xxxxxxx>
- Date: Mon, 11 Oct 2021 10:39:41 +0100
- Cc: bertrand.marquis@xxxxxxx, wei.chen@xxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Mon, 11 Oct 2021 09:39:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Luca,
On 11/10/2021 09:03, Luca Fancellu wrote:
+static bool __init is_boot_module(int dt_module_offset)
+{
+ if ( (fdt_node_check_compatible(fdt, dt_module_offset,
+ "multiboot,kernel") == 0) ||
+ (fdt_node_check_compatible(fdt, dt_module_offset,
+ "multiboot,ramdisk") == 0) ||
+ (fdt_node_check_compatible(fdt, dt_module_offset,
+ "multiboot,device-tree") == 0) )
+ return true;
A boot module *must* have the compatible "multiboot,module". I would
prefer if we simply check that "multiboot,module" is present.
This will also make easier to add new boot module in the future.
+
+ return false;
+}
+
Cheers,
--
Julien Grall
|
