[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 01/17] xen/pci: Refactor MSI code that implements MSI functionality within XEN
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 30 Sep 2021 16:22:46 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=J8nakvMkRLnc7FFQUjjQiIHAtqM9aF1YkbrbFKHyJKI=; b=FVn8mKe6edXl4nwDGEd/cXZhsTqIgFBR++qx+UdOh1ry5W3u/LOm+wgezStMXdMD4pxK0Bk7z/b/g+M3mMlSd6NcrJKZLhkwq1DnuRjLGxVDFYezknd5lXCTWwPrLSiRrRrloS1rAxIPOguDMiS1+rspll3LQbdKt/vTseJbGO3aizNzLqrtP53aSi689jMRAYDRF1S4GP8j35iP7S+WiVYnSUQKggbyvmv2c6nij+LqCiHyhU+VkAFxjPOABm8SFORMCtJc4uikE76bnNsjDQT1e8Ng66mSFfDyEWHyCEsKjazD8lNFfWB1K+FSZVTQ2437vasWaocbjExzoVuizg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QvTDl67UkcmD2uGX2lzzT9eGyXRASCOimsNGw77Wu0iGILg5PwsM4fiNRl0TQ+IfVrqFuERIwq+VKw4WuAPmfnQpxnI0qgkxzZUTcag6qAKH2Js0kFhTtWRMjb538mnKMVRo1mnCDdQlY1F8/rCLp2T7MamSpQzpQ3IMd2h2FYv+Hb7F7GIcY7dc3MLeOUZU+4CSgQW9KauX7DUHRpWYdZV6tJ/nM1P2UF/u+G+A7jegU4dlpMW5A3dbCAcUysRriedpglzIU36R1WBJ+1RRhUg4xclPf4Lhg7vVeuv7QNpf7ppGQatemtDoqQ0Cg7gKywvz5LvFf2J7nglWXE+oxQ==
- Authentication-results: apertussolutions.com; dkim=none (message not signed) header.d=none;apertussolutions.com; dmarc=none action=none header.from=suse.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, bertrand.marquis@xxxxxxx, Andre.Przywara@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 30 Sep 2021 14:23:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29.09.2021 18:56, Stefano Stabellini wrote:
> On Tue, 28 Sep 2021, Rahul Singh wrote:
>> On Arm, the initial plan is to only support GICv3 ITS which doesn't
>> require us to manage the MSIs because the HW will protect against
>> spoofing. Move the code under CONFIG_HAS_PCI_MSI flag to gate the code
>> for ARM.
>>
>> No functional change intended.
>>
>> Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx>
>> Reviewed-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Nevertheless I'd like to express that ...
>> --- a/xen/drivers/pci/Kconfig
>> +++ b/xen/drivers/pci/Kconfig
>> @@ -1,3 +1,7 @@
>>
>> config HAS_PCI
>> bool
>> +
>> +config HAS_PCI_MSI
>> + bool
>> + depends on HAS_PCI
... personally I think this should be "select HAS_PCI", and the then
redundant one in x86 might then want dropping.
Jan
|
