[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 03/17] xen/arm: solve compilation error on ARM with ACPI && HAS_PCI
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Wed, 29 Sep 2021 09:29:20 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=HgDWpFjyYRgPv97da3w2BM8h441w53bay0cYkUStBkg=; b=VrCMAHuFk6rtkcOOzNEHOJfyxt6W3ZbLjKeGO89vbaxKJzZcJPQBJdmHX2ya78xvnjny8HEQf6darJDBk5+f3WT4JtgSDUGr57svB4hngvGbCUzRfXMfjPA9fpixHeJztz5PvPdVzJcrvRZK9RFd/Vxs5Xr1FdJji0GY0AJsMzem/Swcki3exh/dGzchhXI9akk4GmPLyN4cxbEzS1fBOmVuatNqUVomvemgOPue1Kn+keA0hdmqm+kzpg/4gK7xJ0qgxxKwxt7ps6rVPEFyZT7StERmhxRyTLRdHZUjZpz80Rkn8cKorg7icViz7kU8guNLB2jKdwXHnXhpl9DLpw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WVJBVCWL8/kQjmzo2Njs3103WNqCSmo+01GG2v8oJuYBt1aWUbNvbA4MFP83Tpf1e6q0nW+y8DtV7WK5n6SEsAalhNeoxsUKUoERSUQi9S8MHcE+JWIRpZuyGQ4+qpaOmeGrHc5e/A0v5VR3RVvqyE4duVOOkFURA34ZKr7MeqWKHgAefky+egZEdbLdzoZZJSDoii0SrSZyQ634vLo3ooeF5h38i/cZKMQgakfFjPXLC4f1MM+cLNiImHQZfmLFRSReujjZy+5bRiUajbRiZWq6IwVjNC6PxphoWxPDmOJ0Nv0qBebxA2yn4jl75EKjkWkbtsqVofJay0E4haLU/w==
- Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Andre Przywara <Andre.Przywara@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 29 Sep 2021 09:29:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXtJV6eXi8DNccokiopfNmJVlfDau6rZ8AgAASK4A=
- Thread-topic: [PATCH v3 03/17] xen/arm: solve compilation error on ARM with ACPI && HAS_PCI
Hi Jan,
> On 29 Sep 2021, at 9:24 am, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 28.09.2021 20:18, Rahul Singh wrote:
>> prelink.o: In function `pcie_aer_get_firmware_first’:
>> drivers/passthrough/pci.c:1251: undefined reference to `apei_hest_parse'
>>
>> Compilation error is observed when ACPI and HAS_PCI is enabled for ARM
>> architecture. APEI not supported on ARM yet move the code under
>> CONFIG_X86 flag to gate the code for ARM.
>
> Like iirc Julien has pointed out for another, similarly titled patch,
> "solve compilation error" doesn't really seem appropriate here, as
> with the tree at this point of the series no such error should be
> observable. Unless I'm overlooking something.
I wil fix the comment as below:
xen/pci: gate APEI support on ARM
APEI not supported on ARM yet move the code under
CONFIG_X86 flag to gate the code for ARM.
This patch is the preparatory work to enable HAS_PCI on ARM to avoid
compilation error on ARM.
prelink.o: In function `pcie_aer_get_firmware_first’:
drivers/passthrough/pci.c:1251: undefined reference to `apei_hest_parse'
>
> I'd like to suggest that when you receive review comments, you apply
> them throughout the series. If you follow the approach take in the
> other patch ...
Ok. I will take care of this in future patch series.
Regards,
Rahul
>
>> Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx>
>> Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Jan
>
|
