[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 6/6] AMD/IOMMU: expose errors and warnings unconditionally
- To: paul@xxxxxxx
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 28 Sep 2021 09:50:55 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=WnWXYj8LX5CKb3mnxa2+jCxX1IwAdl0UKdT7BrkECrA=; b=fIyeAGdVmwrsvl8FZADDpD1nfm4RI7J7NR35nKurmHcuY91xPgMhgMPvXFZxNNDplcFPubFDra1r1Y3uguONC4yDlU50yWnx8jlM2ILPgAPdahP7gMhNwRZ5ZqHjBSkzc9t+RZPoUG8fmayYgG9fNq2sk6oIjCDx0VkYz9nnMWtvJeUQ5ih0fk+CyNZ30o3CP4bjgxxBcgpWBGNGG5WPF4mfKb/KlaHKnj9BtJx5xxCBeWEtu8/gJlITTrhcFBQtRvrdjbAbLwpfzH7yp8RFjqCzWl+CrL6L81RQB6DhCd6qyYUj3FBCZnzQywVjJTcbJFwp5BStA03wbb0tz0W2ug==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kafbRu4WxxJzJzkxEkfhyx2hPqc3gzj+y/Lv5Js/41K6/Ruu0xJ3vpxeB+o19saSkzrcnMRohihUiFvMHjm0ukkH6R15Oi+J6g3K7h2/qXrvxbD8UmfZAtC1PvHUH1asgP3HxKuvX5fb8zxqWLJQ4AelskMCTjB0rdQzt65Tx264bTU7+6XZG1mD8iVSGuFiv0xGpq97M9YES93FZs0F/RKUvq5zKuSV3i9KqN1t6KOAU4oj94t0sdM2+VRRUkrSGUjepLW8fRKSJpBn30POOuouARvOEt+qG/kQOrgn535H4wsGn6AM+LIt9J6YFQd/Hi/ygeA9gTu5o6AFa//Clw==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 28 Sep 2021 07:51:06 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28.09.2021 09:42, Durrant, Paul wrote:
> On 22/09/2021 15:38, Jan Beulich wrote:
>> Making these dependent upon "iommu=debug" isn't really helpful in the
>> field. Where touching respective code anyway also make use of %pp and
>> %pd.
>>
>> Requested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Reviewed-by: Paul Durrant <paul@xxxxxxx>
Thanks.
>> @@ -515,14 +513,13 @@ static u16 __init parse_ivhd_device_rang
>> dev_length = sizeof(*range);
>> if ( header_length < (block_length + dev_length) )
>> {
>> - AMD_IOMMU_DEBUG("IVHD Error: Invalid Device_Entry Length!\n");
>> + AMD_IOMMU_ERROR("IVHD: invalid Device_Entry length\n");
>> return 0;
>> }
>>
>> if ( range->end.header.type != ACPI_IVRS_TYPE_END )
>> {
>> - AMD_IOMMU_DEBUG("IVHD Error: "
>> - "Invalid Range: End_Type %#x\n",
>> + AMD_IOMMU_ERROR("IVHD Error: invalid range: End_Type %#x\n",
>
> NIT: I guess you want to drop the 'Error' here like you did elsewhere.
Yes indeed. Fixed. Thanks for spotting.
Jan
|
