[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 20/37] xen: introduce CONFIG_EFI to stub API for non-EFI architecture
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Wei Chen <Wei.Chen@xxxxxxx>
- Date: Fri, 24 Sep 2021 10:31:03 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=DNqoZ/UOsh2oKbYQi+6YlA+8uaNRduIatnzyl5VMi+o=; b=NtIbFlRMeWqS+UDS8wWVONBEAFaf4KCyN//6nGWF4gOYnFm1FTwKzRcFALyk9yshrnCpNxOHbOCoUiTtZiIH//5SkabHJ5gEP/v58ouRaUeL4Xaa5vjYlntqvAOc3v3OxFaMx3lkT5X98nNHwnr0wNdwOhbwukAYIZRKMLf2WTK5g4wTAZHM92Ditbo1pizO+JhUPq/5+GDqXjdKy6gX+5zIxoguiM458BFZIJdLTaMVhgseqZoE13Acp5sGX2U0JSVQGDXuWZEfhUmAF+QtUyoSChLpNPpYonWSOLgJNudF94SrEcQ9JNrVBZZNhyC3qSf9XM5E52XT38wnfWWL+g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ty8STzCIhOTToQA73yRr23B4SKIY23S9XnbxUzwWs0u8RFAld3lBnA4C45nqafDLM/UPrV89qWm+qXUApwM4kT0r0IYk+wUZvqxPyMqJvZ87YSbr6TdJTkvMOf2PRzzvSBszJqrV9PavBiYtBfelCSuOHCszhsa+233YCua2I9qjInSEDzu0J9KAh7hGFgBxfkG99LlLTgwuZuNYBJ+F2fLdH33E5cwxQAGXKfpFnA683cXolPnAbdMUQd9YC1oIvGAAyNSuo7kguZrldhWc20W/8X+trneDrGcExH8+bsxWbllV+dg5IdaMPXEbY9OOUfWv4bvOPHv8AKt1bHocsw==
- Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Fri, 24 Sep 2021 10:31:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXsHMtR+l18+MmpE6rl/RjSXTBgquyYmkAgAA2xQCAADnbAIAAKWhQ
- Thread-topic: [PATCH 20/37] xen: introduce CONFIG_EFI to stub API for non-EFI architecture
Hi Jan,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: 2021年9月24日 15:59
> To: Wei Chen <Wei.Chen@xxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx; julien@xxxxxxx; Bertrand Marquis
> <Bertrand.Marquis@xxxxxxx>; Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Subject: Re: [PATCH 20/37] xen: introduce CONFIG_EFI to stub API for non-
> EFI architecture
>
> On 24.09.2021 06:34, Wei Chen wrote:
> >> From: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> >> Sent: 2021年9月24日 9:15
> >>
> >> On Thu, 23 Sep 2021, Wei Chen wrote:
> >>> --- a/xen/common/Kconfig
> >>> +++ b/xen/common/Kconfig
> >>> @@ -11,6 +11,16 @@ config COMPAT
> >>> config CORE_PARKING
> >>> bool
> >>>
> >>> +config EFI
> >>> + bool
> >>
> >> Without the title the option is not user-selectable (or de-selectable).
> >> So the help message below can never be seen.
> >>
> >> Either add a title, e.g.:
> >>
> >> bool "EFI support"
> >>
> >> Or fully make the option a silent option by removing the help text.
> >
> > OK, in current Xen code, EFI is unconditionally compiled. Before
> > we change related code, I prefer to remove the help text.
>
> But that's not true: At least on x86 EFI gets compiled depending on
> tool chain capabilities. Ultimately we may indeed want a user
> selectable option here, but until then I'm afraid having this option
> at all may be misleading on x86.
>
I check the build scripts, yes, you're right. For x86, EFI is not a
selectable option in Kconfig. I agree with you, we can't use Kconfig
system to decide to enable EFI build for x86 or not.
So how about we just use this EFI option for Arm only? Because on Arm,
we do not have such toolchain dependency.
> Jan
|
