[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 36/37] xen/arm: Provide Kconfig options for Arm to enable NUMA


  • To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • From: Wei Chen <Wei.Chen@xxxxxxx>
  • Date: Fri, 24 Sep 2021 18:13:18 +0800
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=g0p843kXw5D0c+OyBjvTrcjNQBSNRMvYTz/gjTVOgj8=; b=ItUY7mK6QMxy5R2mF87i6GXlZB8/7uYeRqb8CV6NveaNMkuyLvWcTHpEDXxdSsSZexwHX4VyslKy5hjpaTfWkaVcGI+/Tpqx8GwFI5BNv/3KkJMus9Sht8G6N+ByZ7n+/EW0j/DfurBFvYMRA21GBhvYIjoMbS/pIL+OHDI2gqu1FbFDw9efJOtohKCpOtm/s3n52Fvu5eWoN9x6G4p/A0+xWwPL3y8fhjgPFx7Vd2MMrZwxrcv0yJdsReaiJtrjfz4vkvFk7sAHanY8FrPCgp0cncbcDHkmWt6EWKssYae5kk2EgjwoPbnZMmlufw+Cgi8wzWLLPXJFquwVHE656Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fhpabmuyDqh4ZifmhBLFKBmOblX+StqJluU61IZdVkQYizFuEzhmK+Jueopjj9HDegg0i1Pw63rVJx0mCz6ebtO3/BIEELA6693HHyeQ0dC1A3Jckb5KoSwI4y4uJM8PPUUZPozsF8MaOsqTjcsaocOP/MzqHxpqrWP16IqIXccwe3hBpQav5YcxelAlI+O6EtoSy+TsHo5RkKqZnd7qWEmLRvQZst0QVMSPBrqTfF+VD3XiXPIT7qZDUHc7+fZgye7EuVD0bwLxGYYlIt5e7Oc97ijPCHqD7wOdi51uentYmmX7lQieSUD2TZtJZ1S9c/L0/EKs1vu3dDzw9OB6og==
  • Authentication-results-original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, julien@xxxxxxx, Bertrand.Marquis@xxxxxxx
  • Delivery-date: Fri, 24 Sep 2021 10:13:52 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;

Hi Stefano,

On 2021/9/24 11:31, Stefano Stabellini wrote:
On Thu, 23 Sep 2021, Wei Chen wrote:
Arm platforms support both ACPI and device tree. We don't
want users to select device tree NUMA or ACPI NUMA manually.
We hope usrs can just enable NUMA for Arm, and device tree
           ^ users

NUMA and ACPI NUMA can be selected depends on device tree
feature and ACPI feature status automatically. In this case,
these two kinds of NUMA support code can be co-exist in one
Xen binary. Xen can check feature flags to decide using
device tree or ACPI as NUMA based firmware.

So in this patch, we introduce a generic option:
CONFIG_ARM_NUMA for user to enable NUMA for Arm.
                       ^ users


OK

And one CONFIG_DEVICE_TREE_NUMA option for ARM_NUMA
to select when HAS_DEVICE_TREE option is enabled.
Once when ACPI NUMA for Arm is supported, ACPI_NUMA
can be selected here too.

Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
---
  xen/arch/arm/Kconfig | 11 +++++++++++
  1 file changed, 11 insertions(+)

diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index 865ad83a89..ded94ebd37 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -34,6 +34,17 @@ config ACPI
          Advanced Configuration and Power Interface (ACPI) support for Xen is
          an alternative to device tree on ARM64.
+ config DEVICE_TREE_NUMA
+       def_bool n
+       select NUMA
+
+config ARM_NUMA
+       bool "Arm NUMA (Non-Uniform Memory Access) Support (UNSUPPORTED)" if 
UNSUPPORTED
+       select DEVICE_TREE_NUMA if HAS_DEVICE_TREE

Should it be: depends on HAS_DEVICE_TREE ?
(And eventually depends on HAS_DEVICE_TREE || ACPI)


As the discussion in RFC [1]. We want to make ARM_NUMA as a generic
option can be selected by users. And depends on has_device_tree
or ACPI to select DEVICE_TREE_NUMA or ACPI_NUMA.

If we add HAS_DEVICE_TREE || ACPI as dependencies for ARM_NUMA,
does it become a loop dependency?

https://lists.xenproject.org/archives/html/xen-devel/2021-08/msg00888.html

+       ---help---
+
+         Enable Non-Uniform Memory Access (NUMA) for Arm architecutres
                                                       ^ architectures


+
  config GICV3
        bool "GICv3 driver"
        depends on ARM_64 && !NEW_VGIC
--
2.25.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.