[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 10/37] xen/x86: use helpers to access/update mem_hotplug
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Wei Chen <Wei.Chen@xxxxxxx>
- Date: Fri, 24 Sep 2021 04:29:31 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=v3/But/Psy4Wob6vpKoPsMIkVP5NEP9GBQsgC6TY/NY=; b=iD302siRU0eH1MbT92gPTsdVNZFLYjTey6zP5f+xYvm0VdTZNk0t9cHDuLdeZuGqauSh5WYdshfBa+pTJoN8cBNV3wPAdBFyjIo9tvd5ZIun9iRoBdzTEoxaQXGsPrNTjQVrvueVDYKl2c9EQNPEJIYXSBlTKfxeDO1QrLdwctCPNajCPrivcYKTzVC0uDbkovrEl88+AQXkhJ2hwdYn1/zxuE9LClViNvWFCFTzz+8WBeBeF+kg2Zbr0VaQrF/2x7YlptGIfEht/rqe994fybZmRKc3xkAauEHy4YrJfo3Q1fCzyWwunFyybchSwYhmHqWIo1YmMz96PJ6ykIIjJQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IJzuc2vJMhaSmWrAyt1qRCOfmJIAsEyqDZmMvBfUmqV0s4PCT4PERPBQadcHQtcepdJEnOOMJIP8wsbKEGECyNOJS/T76oYKCQohb/WofAv+2voslHwPTyZWYLDe/85oj1ZS07QJarEIEQ9APezpfdeL9YCDK0ebhDwMYJww/eqdES+XSd3xQoy95D7yNCi7r4BybUZ+39DM6hoON1uwJD6EQstwG2KwEiyn9m2LjaJfxTIcv+EGH5upyLLxKtL5+AZVLCXFunMH0B7Mb88pmHScgw2gQf/kifRhmKMrbVkWBQmwT7TEJ0c466KctDoT8JQNTvtncYOOJfV18qZlpA==
- Authentication-results-original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>
- Delivery-date: Fri, 24 Sep 2021 04:30:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXsHMVa+NLaHkUKUKV++B1/dWC4quyVkOAgABCPlA=
- Thread-topic: [PATCH 10/37] xen/x86: use helpers to access/update mem_hotplug
> -----Original Message-----
> From: Xen-devel <xen-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf Of
> Stefano Stabellini
> Sent: 2021年9月24日 8:32
> To: Wei Chen <Wei.Chen@xxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx; sstabellini@xxxxxxxxxx; julien@xxxxxxx;
> Bertrand Marquis <Bertrand.Marquis@xxxxxxx>; jbeulich@xxxxxxxx;
> andrew.cooper3@xxxxxxxxxx; roger.pau@xxxxxxxxxx; wl@xxxxxxx
> Subject: Re: [PATCH 10/37] xen/x86: use helpers to access/update
> mem_hotplug
>
> +x86 maintainers
>
>
> On Thu, 23 Sep 2021, Wei Chen wrote:
> > We want to abstract code from acpi_numa_memory_affinity_init.
> > But mem_hotplug is coupled with x86. In this patch, we use
> > helpers to repace mem_hotplug direct accessing. This will
> ^ replace
>
> > allow most code can be common.
> ^ to be
>
> I think this patch could be merged with the previous patch
>
Ok, I will do it, and fix above typos
>
> > Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
> > ---
> > xen/arch/x86/srat.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c
> > index 2f08fa4660..3334ede7a5 100644
> > --- a/xen/arch/x86/srat.c
> > +++ b/xen/arch/x86/srat.c
> > @@ -391,8 +391,8 @@ acpi_numa_memory_affinity_init(const struct
> acpi_srat_mem_affinity *ma)
> > memblk_nodeid[num_node_memblks] = node;
> > if (ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) {
> > __set_bit(num_node_memblks, memblk_hotplug);
> > - if (end > mem_hotplug)
> > - mem_hotplug = end;
> > + if (end > mem_hotplug_boundary())
> > + mem_hotplug_update_boundary(end);
> > }
> > num_node_memblks++;
> > }
> > --
> > 2.25.1
> >
|