Re: [PATCH v2 12/12] x86/trace: Clean up trace handling

[Jan Beulich <jbeulich@xxxxxxxx>]

On 20.09.2021 19:25, Andrew Cooper wrote:
> Use more appropriate types.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
with a suggestion:

> @@ -48,30 +45,28 @@ void __trace_pv_page_fault(unsigned long addr, unsigned 
> error_code)
>  
>      if ( is_pv_32bit_vcpu(current) )
>      {
> -        struct __packed {
> -            u32 eip, addr, error_code;
> -        } d;
> -
> -        d.eip = eip;
> -        d.addr = addr;
> -        d.error_code = error_code;
> +        struct {
> +            uint32_t eip, addr, error_code;
> +        } d = {
> +            .eip = eip,
> +            .addr = addr,
> +            .error_code = error_code,
> +        };
>  
>          __trace_var(TRC_PV_PAGE_FAULT, 1, sizeof(d), &d);
>      }
>      else
>      {
>          struct __packed {
> -            unsigned long eip, addr;
> -            u32 error_code;
> -        } d;
> -        unsigned event;
> -
> -        d.eip = eip;
> -        d.addr = addr;
> -        d.error_code = error_code;
> -        event = TRC_PV_PAGE_FAULT;
> -        event |= TRC_64_FLAG;
> -        __trace_var(event, 1, sizeof(d), &d);
> +            uint64_t eip, addr;

Like you've done in __trace_pv_trap() and __trace_ptwr_emulation(),
perhaps name the field "rip" here as well?

Jan