[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 09/12] xen/trace: Minor code cleanup
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 21 Sep 2021 13:03:54 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=o9ZHWeV00VO1M6yzaBpD0BDihqnJQoJNkdDkA7YiaxY=; b=ndsXqRJ8In7kKJRzMfh6CMdFcb/StU+M2jorAhsQAynv/t+ko1thKo/C2JYGj14AQ12+/IzFBKFHCjqLz3OJOLwW+dZ9pSVaRiwSK+JGXtHros+hnTDjtCgp7VMORX0lTlYnQUDqufnXLaOncSio64RiceO1IBQGq7Y6FuNfeye3y1I8Yql8/knbTfRz/FtEbsaRVzwqHk5E5Rk9dCC9D7bFdRdwwzWOUo7s0PsP/3KwOC1+o00jxjkPMaphYqox9+Q5LK0u1v4wqg1jdV7CJggkQ8uxHSm7bJ0lpzQs23txe6CNSkk6729qF6dTucfyF72b6ZYe6ej1/sxhO3Dghg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kHt2S79wS6xuHYXTN3pHMKGdh4BIzkb5va0HE87ZD6vpI7gcp9Krv4NJHlAiEy+BSvp/DBeqSqS0CkdVRr6445Qm0n7Dm++aU6DybEvGQ6gTBo90ElTHI2wlrQD+UZEdGhmEtBM55/XWFvBBX/8d3TMjCL5X2pmLnJhJDTi0ujhT0wYJ6JngSQQwhED3BZFLBKVaqCeldQaTJmo8RgDZMMi5hUAMbJyIoAq03wNBAjqgNPcSc84yVrMsZGDX7mr4dgJS4a60Ngrs7IMEPYCptwyRty/U68ICHptMdKl7aEk7pTUC+xI2GFHMWKw5I+eDc3LwXo31moTjJ/P7BEY14g==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 21 Sep 2021 11:04:06 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 20.09.2021 19:25, Andrew Cooper wrote:
> * Delete trailing whitespace
> * Replace an opencoded DIV_ROUND_UP()
> * Drop bogus smp_rmb() - spin_lock_irqsave() has full smp_mb() semantics.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Like for v1: Largely
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
One remark:
> @@ -717,9 +713,6 @@ void __trace_var(u32 event, bool_t cycles, unsigned int
> extra,
> if ( !cpumask_test_cpu(smp_processor_id(), &tb_cpu_mask) )
> return;
>
> - /* Read tb_init_done /before/ t_bufs. */
> - smp_rmb();
> -
> spin_lock_irqsave(&this_cpu(t_lock), flags);
>
> buf = this_cpu(t_bufs);
I wonder whether the comment wouldn't be helpful to move down here,
in of course a slightly edited form (going from /before/ to /after/).
Jan
|
