[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] common: guest_physmap_add_page()'s return value needs checking
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 21 Sep 2021 12:45:28 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=E8xTm3XLLtFlLVUnoEW45dK7JTjoytq/BFVxDn9O/48=; b=SvbSFrKqk0h69lthlDaaF8JWZ8LWbbvyHlFYXblKokG4w1c3l4xuEd0kTAof2Np/PZai/JeyxQE0+NEvnDfV9RQ/D+m4bdlns9Rix/LYFdlIpW+r+1JnY2VK4wD3iW+sHonET+JOZFG/n5RMe7qSzTdWm13YnpG1JRRV1B9aTHE1xIe4GIknIGrHfl2hHdmjgNfpEJyooi1HSTKaRtmCGbWYdePuJnERXAxnHLgHayOP2dMU3au++5ayiW/cCJULFb4nIWGRpz1LNzD/gQvbNCNg1LhJNhburUAXQ9hqI6evDHW8eAtP5NiG3xsslMpgokQj0nhdndrrIVmlyLLUUw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kCfV3RuOkIEfVXpUvswZGh9AsC6QHW3pNi8AQVQyx8x9p3o+RarByiAoGecXDjcFFW73ypOVA/BewUo0GKFf6SzEXgL6ni4PHNrSxvysJ4YEe/mwgGNbMSurjeJ5GAXltDdyM4DvDtRgfKcqlcDaoaN7PILRy8TC2/C/lN9mo2C8KpMZcWDsmUcrNRmV0BSG6FzBqJPljHFH1BgN9DJ8vDbuj00RavJX2F+4wK4ilDgGf0fHf9W+IHpC4gJS6tf7yoI4ZHbU87/ydi0FAgArkFXbbEHgSQRtJ4MQuvrmYEgKrwaKvEWazx8sbqR/kKr+sV48K5XGSs2i9vo9FQpfeA==
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 21 Sep 2021 10:45:47 +0000
- Ironport-data: A9a23:mvwD4aJZMNH3E1XgFE+RP5IlxSXFcZb7ZxGr2PjKsXjdYENS0jEOm 2oYWD+FM//bN2r3fNFyOdjk9xhQuMXQydZrHARlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZ0ideSc+EH140UM5wrZj6mJVqYPR7z2l6 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2Vj/Rd+ YhKpKDuQCYsEKvggekdXBJhRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2XvoYJjW9v36iiG97bR MchcxR2PS/iekNiE1I8LdUmsteR0yyXnzpw9wvO+PtfD3Lo5A5s1LngNvLFd9rMQt9a9m6Dv X7P9Wn9BhAcNfScxCCD/3bqgfXA9QvkXKoCGbv+8eRl6HWRzGEODBwdVXOgvOK0zEW5Xrp3O 0ESvyYjs6U23EiqVcXmGQ21pmaeuRwRUMYWFPc1gCmM1aj88wufHnIDTDNKdJohrsBeeNAx/ gbXxZWzX2Up6eDLDyLGnluJkd+sETQFCUMzOCgVcVUMwtzNpq0qgxLARe82RcZZkebJ9SHML yGi9XZl3uVI3J9Tjc1X7nic3Gn9/cGhohodo1yNBzP7tFsRiJuNOtTwgWU3+8qsO2pworOph 3ECh8HWx+QHF5jleMelEbhVQe3BCxpoNlThbb9T83sJrG/FF52LJ9k4DNRCyKBBaJ1sRNMRS BWP0T69HbcKVJdQUUOSX25WI59wpZUM6Py/DqyEBjawSsEpKWdrAx2ClWbPhjuwwSDAYIkUO IuBcNbEMJrpIf08l1KLqxMm+eZznEgWnDqLLbiilkjP+efONRa9FOZeWHPTP79R0U9xiFiMm zqpH5DRkEs3vSyXSnS/zLP/2nhQfCBnWsip+5IIHgNBSyI/cFwc5zbq6epJU6RunrhPl/eO+ Xe4W0RCz0H4i2GBIgKPAk2Popu1NXqmhX5kbyEqI3iy3H0vPdSm4KsFLsNldrg77u1zi/VzS qBdKcmHB/1OTBXB+igcMsah/NAzKkzziFLcJTehbRg+Y4VkG17D9Oj7c1a97yIJFCe265cz+ uXyygPBTJMfbA1+F8KKOum3xla8sCFFyuJ/VkfFOPdJf0Do/NQ4IiD9lKZvccoNNQ/C1n2R0 APPWUUUouzEookU9tjVhP/b89f1QrUmRkcDRjvV97e7MyXe71GP+44YXbbaZy3ZWUP15L6mO bdfwcbjPaBVh11NqYd9TepmlPps+9v1qrZG5Q14B3GXPU+zA7ZtL3Taj8lCsqpBmu1QtQesA x/d/9BbPfOCOd//EU5XLw0gN7zR2fYRkzjUzPI0PESlu3MnoOvZCR1fb0uWlShQDLppK4d0k +4utfkf5xG7lhd3YM2NiTpZ9jjUI3ENO0n9Wkr23GM/ZtIX92x/
- Ironport-hdrordr: A9a23:nUWDfaA1x+GYHQnlHemo55DYdb4zR+YMi2TDgXoBLSC9E/b5qy nApp8mPHPP4gr5O0tApTnjAsa9qCjnhPtICOAqVN+ftW/d1VdAR7sN0WKN+VHd84KVzJ876U /NGZIOa+EZrDJB/KTH3DU=
- Ironport-sdr: PORsFy2C0OWrR0iEk11lTFYMFXLA6mVPpzZEYxfIkw6pvjVpjOQLNpYEWPU92pCQdElDrdL3oT 1aH2fKAOGlUah/KiaL+tRWte9sdVc0ZruzGRPok7xuIJR3lgpiAOejx3bdcIRLs8CLnebfijmv WH1Q/iUCs0bGw7KYrHOReltAg8tzR3gjTDvml/zkIOwAfPmoZhasOSh6kQXu2SlrWSRYOtXQ5J Cr0nKxq37filNxlZ26xFj7/dEjsIxNn84Ia2QfCbLfrJmkhgi1OroWaCdrb862rQIj5WoiQOMJ D1Dv273FzOYTzK1s/D7lXuk6
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Sep 21, 2021 at 12:28:12PM +0200, Jan Beulich wrote:
> On 21.09.2021 11:20, Roger Pau Monné wrote:
> > On Wed, Sep 01, 2021 at 06:06:37PM +0200, Jan Beulich wrote:
> >> The function may fail; it is not correct to indicate "success" in this
> >> case up the call stack. Mark the function must-check to prove all
> >> cases have been caught (and no new ones will get introduced).
> >>
> >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> >
> > Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>
> Thanks. Albeit strictly speaking an ack here isn't enough for the change
> to go in, it would need to be R-b or come from a REST maintainer.
Oh, FE:
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks, Roger.
|
