[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v3 8/9] x86/HVM: skip offline vCPU-s when dumping VMCBs/VMCSes


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 21 Sep 2021 09:20:32 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=CbSaBreuvDjQILv0E6xjB0s8ZsBQ3dj8qUpxvESe3zI=; b=IkEnAcKI3UGrNqS9FrEQ3+KQroOdo4HZHmxOSqhPlqPIFEKd/hK0kRv+mMPPA1rky+dq9nD7MzLD23xOjsLQ4a7OpuBMN1Joo8OHA5woI1wX2asxkGsVbomgY8RYdT//RU/hWNheCkU1GsOmBbUs76PKEfuIxc3e5DbAZEDbDfdoT8KK/D5WHSin1453/ZvhAR1J+xVLRfT1rl9j5YzH/uznRObi8+Gx0rapo4AnAIucujWvH5ic1qbbjod+q1mdZrt4wHjxT74k0lXu+lH7A6fVW1eKrdDUycFZVx34DLt88GDG6bDFIm8gbKNvFMO5PPCtcPe1HK7hvSS8j0MDFQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B2LUX0fRf98D5C0FwNwL9PbS7MLydFyLc2nBVrxWhqNeWhyMcotO4TF5BCnrHIn1tQMdOf7ThpICfDeoKJu0/WFA7j0ux2dmw/MvSlDpg/cZbGoYnB2bdXym+xYbUURDnc84ycAvJv+S3B3PWcvTPkOEyWem/+jdOVegbm35JnOo6FAlJ2z/PSFMbchyamF7rFq+fUpSBCBXa+bqBffP1JXFR7+bl2wCPsBNsSL8DbK0z0Pov6UViUT4aOq+pOyXgXJd34gg/A+69qqJP8ftO8S6P41xChozLhegmSvONpKJt23FtrxNXYO79obOdSiwTispji0a8fQrfAT9U96w0w==
  • Authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>
  • Delivery-date: Tue, 21 Sep 2021 07:20:47 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

There's not really any register state associated with offline vCPU-s, so
avoid spamming the log with largely useless information while still
leaving an indication of the fact.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
---
v2: New.

--- a/xen/arch/x86/hvm/svm/vmcb.c
+++ b/xen/arch/x86/hvm/svm/vmcb.c
@@ -242,6 +242,11 @@ static void vmcb_dump(unsigned char ch)
         printk("\n>>> Domain %d <<<\n", d->domain_id);
         for_each_vcpu ( d, v )
         {
+            if ( test_bit(_VPF_down, &v->pause_flags) )
+            {
+                printk("\tVCPU %u: offline\n", v->vcpu_id);
+                continue;
+            }
             printk("\tVCPU %d\n", v->vcpu_id);
             svm_vmcb_dump("key_handler", v->arch.hvm.svm.vmcb);
         }
--- a/xen/arch/x86/hvm/vmx/vmcs.c
+++ b/xen/arch/x86/hvm/vmx/vmcs.c
@@ -2133,6 +2133,11 @@ static void vmcs_dump(unsigned char ch)
         printk("\n>>> Domain %d <<<\n", d->domain_id);
         for_each_vcpu ( d, v )
         {
+            if ( test_bit(_VPF_down, &v->pause_flags) )
+            {
+                printk("\tVCPU %u: offline\n", v->vcpu_id);
+                continue;
+            }
             printk("\tVCPU %d\n", v->vcpu_id);
             vmcs_dump_vcpu(v);
         }




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.